Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request & Issue Templates #172

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Pull Request & Issue Templates #172

merged 2 commits into from
Jul 9, 2024

Conversation

flxst
Copy link
Member

@flxst flxst commented Jul 4, 2024

What does this PR do?

This PR

  • improves the current pull request template
  • adds several issue templates (bug report, documentation, feature request, blank)

General Changes

  • none apart from the above

Breaking Changes

  • none

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)

@flxst flxst self-assigned this Jul 4, 2024
@flxst flxst requested review from mali-git and le1nux July 4, 2024 06:07
le1nux
le1nux approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for setting it up. LGTM :-)

@le1nux le1nux merged commit f704013 into dev_experiments Jul 9, 2024
3 of 5 checks passed
@le1nux le1nux deleted the feat/templates branch July 9, 2024 08:45
@le1nux le1nux mentioned this pull request Jul 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le1nux le1nux le1nux approved these changes

@fromm-m fromm-m fromm-m approved these changes

@mali-git mali-git Awaiting requested review from mali-git

Assignees

@flxst flxst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flxst @le1nux @fromm-m