Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unique Experiment ID #181

Merged
merged 4 commits into from
Jul 11, 2024
Merged

feat: Unique Experiment ID #181

merged 4 commits into from
Jul 11, 2024

Conversation

mali-git
Copy link
Member

@mali-git mali-git commented Jul 11, 2024 •
edited
Loading

What does this PR do?

This PR ensures that experiment IDs are unque.

General Changes

  • Append a hash value that is build based on the config file path to the experiment ID

Breaking Changes

  • None

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)

@mali-git mali-git requested a review from le1nux July 11, 2024 09:14
@le1nux le1nux requested a review from fromm-m July 11, 2024 10:25
@le1nux le1nux added the enhancement New feature or request label Jul 11, 2024
le1nux
le1nux approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@le1nux le1nux merged commit 66c5bfa into main Jul 11, 2024
0 of 3 checks passed
@le1nux le1nux deleted the unique_experiment_id branch July 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le1nux le1nux le1nux approved these changes

@fromm-m fromm-m Awaiting requested review from fromm-m

Assignees

@mali-git mali-git

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mali-git @le1nux