Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: removed packaging from pyproject #182

Merged
merged 22 commits into from
Jul 11, 2024
Merged

bugfix: removed packaging from pyproject #182

merged 22 commits into from
Jul 11, 2024

Conversation

fromm-m
Copy link
Member

@fromm-m fromm-m commented Jul 11, 2024 •
edited

What does this PR do?

This PR has the goal that tests and linting is running through properly.

General Changes

  • ..

Breaking Changes

  • ..

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)

@fromm-m fromm-m self-assigned this Jul 11, 2024
@fromm-m fromm-m linked an issue Jul 11, 2024 that may be closed by this pull request
Packaging dependency not correctly installed during test pipeline execution #177
Closed
@fromm-m fromm-m requested a review from le1nux July 11, 2024 08:32
@fromm-m fromm-m marked this pull request as draft July 11, 2024 08:42
@fromm-m fromm-m requested review from le1nux and removed request for le1nux July 11, 2024 08:44
@fromm-m fromm-m requested review from le1nux and removed request for le1nux July 11, 2024 08:55
@fromm-m fromm-m requested a review from mali-git July 11, 2024 13:13
@fromm-m fromm-m requested review from mali-git and removed request for mali-git July 11, 2024 13:15
@fromm-m fromm-m marked this pull request as ready for review July 11, 2024 13:17
@le1nux le1nux added the bug Something isn't working label Jul 11, 2024
@fromm-m fromm-m merged commit 06afc42 into main Jul 11, 2024
7 checks passed
@fromm-m fromm-m deleted the 177-packaging-dependency-not-correctly-installed-during-test-pipeline-execution branch July 11, 2024 13:29
@fromm-m fromm-m mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le1nux le1nux le1nux approved these changes

@mali-git mali-git Awaiting requested review from mali-git

Assignees

@fromm-m fromm-m

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging dependency not correctly installed during test pipeline execution
3 participants
@fromm-m @le1nux @mali-git