Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for using multiple losses and metrics in evaluator #8

Closed

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    7ef1362 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    69134ad View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Configuration menu
    Copy the full SHA
    af47020 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    abd2268 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. feat: started implementation of Aggregator and StatefulMetrics

    Co-authored-by: Teucher, Roman <[email protected]>
    le1nux and Teucher, Roman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3519217 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    48e4a89 View commit details
    Browse the repository at this point in the history
  2. feat(evaluation): Adding generic evaluation measure for training

    * adding generic measure class
    * adding perplexity as well as cross entropy loss computations
    * starting unit tests
    Roman Teucher committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    cd15bbd View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. feat(evaluation): various updates

    done:
    - integrated new aggregated measures into evaluator
    - updated and expanded evaluator tests
    - extracted throughput measurement into class
    - fixed missing keys in measure implementations
    - code clean up
    todo:
    - integration into trainer
    - parameterization f eval losses/metrics
    - testing the loss implementations (in particular perplexity)
    BlueCrescent committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    317978b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2678d05 View commit details
    Browse the repository at this point in the history
  3. refactor(evaluation): integration of evaluators in training

    * add aggregative measure factories to constructor of Evaluator
    * extract big train method into smaller ones
    * adapt test_evaluator to new params of changed Evaluator class
    * gym: remove loss functions and metrics for evaluation from evaluation method
    Roman Teucher committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    efd97e6 View commit details
    Browse the repository at this point in the history
  4. refactor(evaluation): adaptions to loss function; using conftest.py f…

    …ixtures
    Roman Teucher committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5034018 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2da315 View commit details
    Browse the repository at this point in the history
  6. feat(config): added first version of evaluation losses in config

    WIP: The current version does not yet work.
    BlueCrescent committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    09f1078 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    c6b0a1b View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. feat(evaluation): add factory for ThroughputAggregator, finish perple…

    …xity impl and test
    
    * add throughput aggregator factory callable; needed because otherwise it was intantiated in the class itself and was not mockable
    * fix perplexity computation: now tracking losses, summing over them and then computing torch.exp(loss_sum/#samples)
    *
    Roman Teucher committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    66a9971 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. fix(evaluation): Fixed perplexity and finalized batch size two test.

    Perplexity now gets computed correctly for each sequence in a batch and summed up afterwards.
    BlueCrescent committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    00f0598 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    59e8996 View commit details
    Browse the repository at this point in the history
  2. test(evaluation): Added multiple dataloadres to evaluator tests.

    Also: Small fix in perplexity tests.
    BlueCrescent committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9af55e4 View commit details
    Browse the repository at this point in the history
  3. fix(loss): Reverted change to cross entropy reduction default back to…

    … "mean".
    
    Otherwise (with reduction="sum"), this would drastically impact training loss.
    Instead, for accumulating and logging the training loss, the added losses now get divided by number of batches instead of the added batch sizes.
    BlueCrescent committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6215257 View commit details
    Browse the repository at this point in the history
  4. fix(evaluation): Fixed parameter for throughput aggregator in Evaluator.

    Also, small refactoring of corresponding tests.
    BlueCrescent committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    bbf4d4f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a113152 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d898e84 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7ea5ed9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c24cf26 View commit details
    Browse the repository at this point in the history
  9. refactor: Ran isort.

    BlueCrescent committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    547c0d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge remote-tracking branch 'remotes/origin/main' into feat/multiple…

    …_losses_and_metrics_in_evaluator
    
    # Conflicts:
    #	config_files/config_example_hf_meditron_7B_instruction.yaml
    #	config_files/config_example_mem_map_dataset.yaml
    #	config_files/config_lorem_ipsum.yaml
    #	src/modalities/__main__.py
    #	src/modalities/config/config.py
    #	src/modalities/config/lookup_types.py
    #	src/modalities/evaluator.py
    #	src/modalities/resolver_register.py
    #	src/modalities/trainer.py
    #	tests/conftest.py
    BlueCrescent committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    066f092 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa004be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    67e77ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb0bc62 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eb5e792 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. chore(merge): Merge remote-tracking branch 'origin/main' into feat/mu…

    …ltiple_losses_and_metrics_in_evaluator
    BlueCrescent committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cc76bdf View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    4e91766 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e12dcd7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8cd8b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    27b0fa8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c886473 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fdd4fa2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    82f5458 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    356c4da View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dba5680 View commit details
    Browse the repository at this point in the history
  10. refactor(evaluation): Adapted evaluator tests to previous renaming of…

    … compute() to aggregate().
    BlueCrescent committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    381caff View commit details
    Browse the repository at this point in the history
  11. feat(evaluation): Changed ThroughputAggregationContext to be usable i…

    …n Trainer instead of iterable decorator.
    
    This code should be better readable than using start_throughput_measurement().
    BlueCrescent committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    362ff84 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. chore(merge): Merge remote-tracking branch 'origin/main' into feat/mu…

    …ltiple_losses_and_metrics_in_evaluator
    BlueCrescent committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    00b8c95 View commit details
    Browse the repository at this point in the history
  2. chore(merge): Merge remote-tracking branch 'origin/main' into feat/mu…

    …ltiple_losses_and_metrics_in_evaluator
    BlueCrescent committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b955e98 View commit details
    Browse the repository at this point in the history