chore: record main-base as a required check on main - #999
Merged
Conversation
The main-base merge-routing job joins main's required status checks (ruleset 'main: require PR'), closing the gap where a mis-routed feature PR went red without being blocked. Updates every surface that records the required set: the pinned list in tests/test_required_checks.py, the ci.yml comments, the promotion section and one-time-setup checklist in docs/pipeline.md, the ruleset inventories in docs/security.md, and the public copy in SECURITY.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… procedure example Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main-basejoinsmain's required status checks (ruleset main: require PR), and every surface that records the required set is updated to match: the pinned list intests/test_required_checks.py(the only unattended enforcement), the ci.yml comments, the promotion section and one-time-setup checklist indocs/pipeline.md, the ruleset inventories indocs/security.md, and the public copy inSECURITY.md.Procedure (docs/pipeline.md, Adding a required status check)
main's ci.yml — done; byte-identical to staging's.scripts/promotion-gate.sh contexts main-base→ ready to require: 'main-base', contexts clean.metrics/refresh) reportedmain-base: SKIPPED— satisfying a required-context rule — and merged. The docs' preferred witness is a collect PR, but predict/evaluate fan-outs are currently held; the metrics-refresh lane exercises the identical merge-ref mechanics (branch cut frommain, auto lane, allowlisted head), so it is the same evidence.403 Resource not accessible by integration) on the ruleset PUT, so the maintainer applies it with their own credential (command in the session report). This PR merges only after that edit lands, so the docs never describe a required set the ruleset does not enforce.Artifact served: the promotion path's integrity — a mis-routed feature PR into
mainis now mechanically blocked, not just flagged red.required_approving_review_countonmainstays0, reaffirmed by the maintainer in-session (docs/security.md already records the policy and its change condition).Gate
lint + test green locally (1629 passed), zizmor 1.26.1 no findings, actionlint 1.7.12 clean.
This touches
.github/workflows/andSECURITY.md— maintainer-lane surfaces; the maintainer directed this change in-session and approved self-merge once reviewers pass. Reviewer subagents (workflow, docs, security, code) run before merge; their resolutions will be noted here if any blocker needs a rebuttal.Closes #918 (reference for the record — the issue will be hand-closed when this merges, since staging merges do not auto-close).
🤖 Generated with Claude Code