This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
JSON::Schema for data validation #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ModelSEED::Configuration is essentially an unstructured JSON file. This can be dangerous since it will allow us to store arbitrary config data in it. - JSON::Schema will validate a JSON document against a defined schema. Using this, we can define an explicit schema for our configuration data and prevent the addition of arbitrary entries in the configuration files of users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experimenting with using the json-schema specification for data validation. Theoretically it can do a lot of the work that we're doing in ModelSEED::MS objects for a lot less in terms of cost (so good for the REST api or something).
The current Perl implementation is a bit buggy, but I've already submitted an RT issue and the maintainer has responded, so it's not a dead project! He's already made the change to fix the bug, linked below. Hopefully support will improve over time.