feat(compiler): expose query operation descriptors - #469
Merged
aaltshuler merged 5 commits intoAug 12, 2026
Merged
Conversation
mrkorchun
force-pushed
the
feat/query-operation-descriptors
branch
from
August 9, 2026 14:51
e8ac2d3 to
b26a099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the first compiler/lint slice of #468.
Summary
operationdescriptor to each successful query-lint result while keeping the existing top-level parameter catalog unchanged;kind, optionalitem_kind, optionalvector_dim, andnullable) rather than string spellings clients would need to parse;not { ... }, mutation targets, edge-insert endpoints, and node-delete cascade edges;operationwhen parsing or typechecking fails.The JSON change is additive. Existing lint fields, top-level parameter metadata, and query behavior are unchanged, so older consumers may ignore
operation.Scope
This PR intentionally stops at the compiler/lint boundary. Projection through
GET /queries, OpenAPI, and the official TypeScript SDK remains follow-up work under #468.Validation
cargo fmt --all -- --checkscripts/check-agents-md.shcargo test -p omnigraph-compiler --locked— 314 passedcargo test -p omnigraph-cli --test cli_data --locked— 77 passedcargo clippy --workspace --all-targets --locked -- -D warnings -W clippy::dbg_macrocargo clippy --workspace --all-targets --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints -- -D warnings -W clippy::dbg_macroRUST_MIN_STACK=16777216 cargo test --workspace --locked --features omnigraph-engine/failpoints,omnigraph-cluster/failpointsThe larger stack is a local macOS test-harness accommodation for the existing large Blob branching fixture; the canonical feature-superset graph then passed in full.
Greptile Summary
Successful query lint results now expose a compiler-owned operation descriptor, while failed queries omit it.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; both previously reported issues are fixed at the current head.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Parsed QueryDecl] --> B[Typecheck] B -->|failure| C[Lint error without operation] B -->|CheckedQuery| D[Describe operation] D --> E[Infer ordered result schema] D --> F[Collect graph reads and writes] E --> G[QueryOperationDescriptor] F --> G G --> H[Successful lint JSON]Reviews (4): Last reviewed commit: "fix(compiler): make operation descriptor..." | Re-trigger Greptile
Context used: