fix(branches): use unique table forks and defer reclamation to cleanup - #695
Merged
azimafroozeh merged 3 commits intoSep 10, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b12d7408ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
azimafroozeh
force-pushed
the
codex/unique-table-fork-names
branch
from
September 9, 2026 23:08
b12d740 to
6d0cfac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
After a fast-forward leaves a child using an owner's earlier table fork, the owner can refuse its next write because the fixed fork name is still occupied. Give each first-touch attempt a bounded, unique fork name and persist it through the existing recovery intent, so subsequent writes preserve the child's snapshot.
Only explicit
cleanupreclaims table forks. Parent deletion records logical retirement in native ref metadata and retains the ancestry needed by descendants. Eligible branch-source fast-forwards adopt table pointers while preserving constraint checks and later write isolation.Backing issue / RFC
Checklist
Local verification
cargo test --workspace --locked --offline --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints --no-fail-fast: 3,256 passed, 24 ignored, zero failures.crates/omnigraph-dst,cargo test --profile dst --locked --offline -p omnigraph-dst --no-fail-fast: 78 passed, 31 ignored, zero failures. The cost golden replays identically.cargo clippy --workspace --all-targets --locked --offline -- -D warnings -W clippy::dbg_macro: passed.cargo clippy --workspace --all-targets --locked --offline --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints -- -D warnings -W clippy::dbg_macro: passed.cargo fmt --all --check, documentation, comment, agent-index, workflow-pin, typo and diff checks: passed.S3/Azure environments and predecessor binaries were not configured locally. CI results are pending.
Notes for reviewers
The internal schema advances to v8 because older engines do not understand retired native refs. The compatibility tests cover refusal and rebuild rather than opening v8 data with an older engine.
The dependency remains unmodified registry Lance 11.0.0. An engine-owned
CommitHandlerpreserves inherited index origins in the existing clone publication, including fragment-reuse details. Nested BTREE, full-text and vector reads are tested through cold reopen. Indexed clone preparation adds metadata reads; ordinary non-clone commits forward without adapter I/O.Retained physical refs can increase cold logical-resolution reads. Native branch retirement retains the existing single-writer-process boundary. Cleanup preserves required ancestors and applies the requested age limit before reclaiming unused forks.