test: separate seam arming references from production crossings - #738
Merged
azimafroozeh merged 2 commits intoSep 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Separate production seam crossings from test arming references in the catalog guard. The current check searches production source for both, so a crossing can satisfy the arming requirement even after the last test reference is removed.
Backing issue / RFC
Accepted issue or RFC link pending. This change does not qualify for the trivial fast-lane.
Checklist
Local verification
rustfmt --edition 2024 --check crates/omnigraph/tests/failpoint_names_guard.rs— passedgit diff --check— passedpython3 scripts/check-docs.py— passed, 142 Markdown files checkedrustc --test— 4 passedNotes for reviewers
Production crossing detection excludes test files and inline test code. Arming references come from integration tests, in-source tests, the DST harness, and
at:values in GQT--- seamsections.The fixtures cover missing arming references, identifier boundaries, exact seam names, and source classification. A separate guard checks for overlapping file sets and installer calls in production text.
Four review findings remain unresolved: block-comment handling,
cfgclassification, installer-name false positives, and differences between the guard’s GQT extraction and the runner’s YAML parser.