Skip to content

branch-protection: allow admin bypass on main #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltshuler merged 1 commit into from
May 15, 2026
Merged

branch-protection: allow admin bypass on main #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/branch-protection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"CODEOWNERS / noedit"
]
},
"enforce_admins": true,
"enforce_admins": false,

@devin-ai-integration devin-ai-integration Bot May 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Documentation not updated to reflect enforce_admins: false, violating AGENTS.md rule #1 and #6

The PR changes enforce_admins from true to false in .github/branch-protection.json but does not update docs/branch-protection.md, which still documents the value as true and states "Even repo admins go through the gates. The point is no bypasses" (docs/branch-protection.md:19 and docs/branch-protection.md:72). This violates two mandatory AGENTS.md rules:

  • Rule Add OpenAPI documentation endpoint and schema #1 (Update in the same PR): "New endpoint, query function, CLI flag, env var, constant, schema construct, or invariant: update both the source code and the doc in the same change. Never split documentation drift into a follow-up."
  • Rule Implement aggregate functions with GROUP BY support #6 (Don't lie): "If a section becomes wrong but you can't rewrite it fully right now, replace the wrong line with *(stale — needs update after <change>)* rather than leaving silently incorrect text."

After this PR merges, the documentation will actively mislead readers about the security posture of the repository.

Prompt for agents 
The change to enforce_admins: false in .github/branch-protection.json must be accompanied by updates to docs/branch-protection.md. Specifically:

1. In the policy table at docs/branch-protection.md:19, change the row for 'Enforce on admins' from value 'true' with rationale 'Even repo admins go through the gates. The point is no bypasses.' to value 'false' with an updated rationale explaining why admin bypass is now permitted.

2. At docs/branch-protection.md:72, update or remove the sentence 'Even repo admins are subject to these rules.' since it will no longer be accurate.

This is required by AGENTS.md rules #1 (update docs in the same PR) and #6 (don't lie in docs).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"required_pull_request_reviews": {
"dismissal_restrictions": {},
"dismiss_stale_reviews": true,
Expand Down