Use the schema of the selected database when running the 'ImportTramslationsCommand'. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohmmedAshraf
force-pushed
the
main
branch
2 times, most recently
from
9f04f9b to
4db0efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application uses multiple databases (for a multi-tenancy structure I will not get into) and I found out that I had to modify the import command to make the
Schema::facade logic work. This is a PR to do that.This is my first open source contribution, please be nice I have missed anything. I really love the package!
You can test this by setting up another database alongside your main database and setting it's connection as the
'database_connection'in the config. Then run the migrations in that database and assert that the import command (andimport --fresh) works. Of course it should also still works if the tables are in the main database and'database_connection'isnull