Skip to content

Conversation

@dbswl701
Copy link
Contributor

@dbswl701 dbswl701 commented Mar 5, 2025

📝 주요 작업 내용

  • 데스크탑 뷰에서 유저의 프로필 보기 버튼 클릭 시 상세 페이지로 이동하던 부분 이벤트 캡쳐링 방지로 해결
  • 데스크턉 뷰에서도 자기 프로필은 안보이도록 수정
  • 유저 프로필, 내가 만든 모임 리스트 스켈레톤 처리
  • 공개 / 비공개 api 연결
  • dropdown 선택된 항목 스타일 변경(disabled 처리-글자 어둡게, cursor-default)

📺 스크린샷

(선택사항)

🔗 참고 사항

다음 진행사항

  • 내가 만든 모임 모임 prefetch 적용
  • 모달 리펙토링

💬 리뷰 요구사항

ex) 중점적으로 리뷰해줬으면 하는 부분

📃 관련 이슈

ex) #이슈 번호

@dbswl701 dbswl701 self-assigned this Mar 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • AI Review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

CI Status Report

검사 결과

  • Lint: ✅ success
  • Format: ✅ success
  • Type Check: ✅ success
  • Tests: ✅ success
  • Build: ✅ success

✅ 모든 검사가 통과되었습니다.

@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for deving-together ready!

Name Link
🔨 Latest commit 5443ae6
🔍 Latest deploy log https://app.netlify.com/sites/deving-together/deploys/67c907e468356c0008524bb7
😎 Deploy Preview https://deploy-preview-50--deving-together.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 38
Accessibility: 95
Best Practices: 83
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

'relative flex w-full cursor-pointer select-none items-center',
'typo-body1 h-[34px] rounded-[10px] px-[12px] py-[8px]',
'text-Cgray400 hover:bg-Cgray300 hover:text-Cgray700',
'text-Cgray400',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 사용되는 곳에서 text-white으로 내려주고있는데 기존 bg 생각해보면 text-white 고정해도 괜찮을것 같아용

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

CI Status Report

검사 결과

  • Lint: ✅ success
  • Format: ✅ success
  • Type Check: ✅ success
  • Tests: ✅ success
  • Build: ✅ success

✅ 모든 검사가 통과되었습니다.

@dbswl701 dbswl701 merged commit 22535fd into dev Mar 6, 2025
6 of 7 checks passed
@dbswl701 dbswl701 deleted the feat/refactor/meeting-created/DEVING-59 branch March 6, 2025 02:27
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

CI Status Report

검사 결과

  • Lint: ✅ success
  • Format: ✅ success
  • Type Check: ✅ success
  • Tests: ✅ success
  • Build: ✅ success

✅ 모든 검사가 통과되었습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants