Feat/refactor/like optimistic update/DEVING-67 #57

lee1nna · 2025-03-07T00:48:25Z

📝 주요 작업 내용

좋아요 낙관적 업데이트 적용
좋아요/좋아요 취소 토스트 바 적용
닉네임 길어질 경우 프로필 이미지 깨짐 현상 수정
카드 그리드 형식으로 수정
헤더 드롭다운 메뉴 오픈 시 우측 여백 생기는 현상 수정

📺 스크린샷

낙관적 업데이트 적용 전
낙관적 업데이트 적용 후
카드 그리드 적용

🔗 참고 사항

ex) 의논할 점, 리뷰어가 알 필요가 있는 추가 정보나 문서, 참고 링크를 포함.

💬 리뷰 요구사항

좋아요 관련 로직을 useLikeHandler 훅으로 별도로 뺐는데, 이 쪽 로직이 조금 복잡해서
더 좋은 방향 있으면 말씀해주시면 감사하겠습니다!

📃 관련 이슈

ex) DEVING-67

coderabbitai · 2025-03-07T00:48:33Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

AI Review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-07T00:48:39Z

✅ Deploy Preview for deving-together ready!

Name	Link
🔨 Latest commit	`3d85dfa`
🔍 Latest deploy log	https://app.netlify.com/sites/deving-together/deploys/67cea4a2320ef900086add29
😎 Deploy Preview	https://deploy-preview-57--deving-together.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 47 Accessibility: 95 Best Practices: 83 SEO: 100 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2025-03-07T00:49:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-03-07T00:50:01Z

CI Status Report

검사 결과

Lint: ✅ success
Format: ✅ success
Type Check: ✅ success
Tests: ✅ success
Build: ✅ success

✅ 모든 검사가 통과되었습니다.

github-actions · 2025-03-10T08:38:19Z

CI Status Report

검사 결과

Lint: ✅ success
Format: ✅ success
Type Check: ✅ success
Tests: ✅ success
Build: ✅ success

✅ 모든 검사가 통과되었습니다.

dbswl701

고생하셨습니다!

dbswl701 · 2025-03-11T01:30:20Z

src/app/meeting/_features/MeetingList.tsx

+  const allMeetings: SearchMeeting[] =
+    data?.pages.flatMap((page) => page.content) || [];
+


flatMap 좋습니다! 하나 배워갑니다!

dbswl701 · 2025-03-11T02:16:25Z

src/service/api/meeting.ts

+  const res = await (token ? authAPI : basicAPI).get(`/api/v1/meetings/top`, {
+    params: { categoryTitle },
+  });


authAPI로 통일해주시면 될 것 같아요!

이후 다른 브랜치에서 통일하도록 하겠습니다!

dbswl701 · 2025-03-11T02:17:41Z

src/components/common/Dropdown.tsx


  return (
-    <DropdownMenuPrimitive.Root onOpenChange={setIsOpen}>
+    <DropdownMenuPrimitive.Root onOpenChange={setIsOpen} modal={false}>


modal 프로퍼티를 설정하신 이유가 궁금합니다!

드롭다운이 modal true가 default인데 이 설정때문에 gnb에서 프로필 클릭시 우측에 스크롤 여백이 나왔었는데,
modal 설정을 false로 해줘야지 해당 이슈가 안생겨서 추가해두었습니당

Lee-Dong-Seok

고생하셨습니다!👍😊

lee1nna added 6 commits March 6, 2025 16:17

feat(DEVING): 좋아요 optimistic update 적용

bcf2621

fix(DEVING-67): 닉네임 길어질 경우 고양이 이미지 깨지는 현상 수정

11d4584

refactor(DEVING-67): 카드 그리드 형식으로 수정

08e9baf

Merge branch 'dev' into feat/refactor/like-optimistic-update/DEVING-67

a67a738

fix(DEVING-67): 헤더 드롭다운 메뉴 클릭 시 우측 여백 생기는 현상 수정

c6ef6bf

fix(DEVING-67): 나의 모임 주석처리 제거

39868dc

lee1nna self-assigned this Mar 7, 2025

github-actions bot added ♻️ refactor ✨ feat 🐛 fix labels Mar 7, 2025

lee1nna added 2 commits March 10, 2025 17:35

Merge branch 'dev' into feat/refactor/like-optimistic-update/DEVING-67

86d50eb

fix(DEVING-67): 모임목록 API 환경변수 제거

3d85dfa

lee1nna requested review from Lee-Dong-Seok and dbswl701 and removed request for dbswl701 March 10, 2025 08:40

dbswl701 approved these changes Mar 11, 2025

View reviewed changes

Lee-Dong-Seok approved these changes Mar 11, 2025

View reviewed changes

lee1nna merged commit f0855ed into dev Mar 11, 2025
8 checks passed

lee1nna deleted the feat/refactor/like-optimistic-update/DEVING-67 branch March 11, 2025 08:12

		const allMeetings: SearchMeeting[] =
		data?.pages.flatMap((page) => page.content) \|\| [];

Feat/refactor/like optimistic update/DEVING-67 #57

Feat/refactor/like optimistic update/DEVING-67 #57

Uh oh!

Conversation

lee1nna commented Mar 7, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 주요 작업 내용

📺 스크린샷

🔗 참고 사항

💬 리뷰 요구사항

📃 관련 이슈

Uh oh!

coderabbitai bot commented Mar 7, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for deving-together ready!

Uh oh!

codecov bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 7, 2025

CI Status Report

검사 결과

Uh oh!

github-actions bot commented Mar 10, 2025

CI Status Report

검사 결과

Uh oh!

dbswl701 left a comment

Choose a reason for hiding this comment

Uh oh!

dbswl701 Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

dbswl701 Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

lee1nna Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

dbswl701 Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

lee1nna Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

Lee-Dong-Seok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lee1nna commented Mar 7, 2025 •

edited by atlassian bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Mar 7, 2025 •

edited

Loading

codecov bot commented Mar 7, 2025 •

edited

Loading