-
Notifications
You must be signed in to change notification settings - Fork 4
feat(DEVING-80): 상세 페이지 모달 패러렐 라우트와 인터셉트 라우트로 변경 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for deving-together ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
CI Status Report검사 결과
✅ 모든 검사가 통과되었습니다. |
lee1nna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!👍
APPROVED, CANCEL, PENDING만 대문자로 폴더명으로 작성된 이유가 있을까용?
버튼 클릭 시 router.push를 통해 백엔드에서 넘어온 상태를 보내주는데, 다른 상태와는 다르게 이 부분만 백엔드에서 대문자로 넘어오더라구요! |
| ment: string; | ||
| setMent: Dispatch<SetStateAction<string>>; | ||
| value: string; | ||
| setValue: Dispatch<SetStateAction<string>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setState 함수를 직접적으로 props로 전달하는 것은 자식 컴포넌트에 부모 컴포넌트 데이터 변경 주도권을 넘겨주는것과 같아서 좋지 않다고 알고 있습니당! 콜백 함수로 감싸서 전달하는 방식이 더 좋을 것 같아요
해당 내용과 관련된 블로그 링크 첨부할테니 참고하시면 좋을 것 같습니다!
CI Status Report검사 결과
✅ 모든 검사가 통과되었습니다. |

📝 주요 작업 내용
📺 스크린샷
(선택사항)
🔗 참고 사항
💬 리뷰 요구사항
ex) 중점적으로 리뷰해줬으면 하는 부분
📃 관련 이슈
ex) #이슈 번호