Skip to content

Conversation

@dbswl701
Copy link
Contributor

📝 주요 작업 내용

  • 상세 페이지에 모달 페러렐 라우트 & 인터셉트 라우트 적용

📺 스크린샷

(선택사항)

🔗 참고 사항

  • 관련 로직이 복잡하여 이전 로직과 분리했는데, 막상 파일 체인지는 얼마 없네용

💬 리뷰 요구사항

ex) 중점적으로 리뷰해줬으면 하는 부분

📃 관련 이슈

ex) #이슈 번호

@dbswl701 dbswl701 self-assigned this Mar 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • AI Review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for deving-together ready!

Name Link
🔨 Latest commit bab603c
🔍 Latest deploy log https://app.netlify.com/sites/deving-together/deploys/67d43b2496cf8500082c023d
😎 Deploy Preview https://deploy-preview-66--deving-together.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56
Accessibility: 95
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

CI Status Report

검사 결과

  • Lint: ✅ success
  • Format: ✅ success
  • Type Check: ✅ success
  • Tests: ✅ success
  • Build: ✅ success

✅ 모든 검사가 통과되었습니다.

Copy link
Contributor

@lee1nna lee1nna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!👍

APPROVED, CANCEL, PENDING만 대문자로 폴더명으로 작성된 이유가 있을까용?

clyde-yoonjae
clyde-yoonjae previously approved these changes Mar 14, 2025
@dbswl701
Copy link
Contributor Author

고생하셨습니다!👍

APPROVED, CANCEL, PENDING만 대문자로 폴더명으로 작성된 이유가 있을까용?

버튼 클릭 시 router.push를 통해 백엔드에서 넘어온 상태를 보내주는데, 다른 상태와는 다르게 이 부분만 백엔드에서 대문자로 넘어오더라구요!
다른 폴더와 통일성을 위해 소문자로 변경해 두겠습니다!

lee1nna
lee1nna previously approved these changes Mar 14, 2025
ment: string;
setMent: Dispatch<SetStateAction<string>>;
value: string;
setValue: Dispatch<SetStateAction<string>>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setState 함수를 직접적으로 props로 전달하는 것은 자식 컴포넌트에 부모 컴포넌트 데이터 변경 주도권을 넘겨주는것과 같아서 좋지 않다고 알고 있습니당! 콜백 함수로 감싸서 전달하는 방식이 더 좋을 것 같아요
해당 내용과 관련된 블로그 링크 첨부할테니 참고하시면 좋을 것 같습니다!

https://velog.io/@thisishwarang/React-setState-%EC%9E%90%EC%B2%B4%EB%A5%BC-props%EB%A1%9C-%EC%A0%84%EB%8B%AC%ED%95%98%EC%A7%80-%EB%A7%90%EC%95%84%EC%95%BC-%ED%95%98%EB%8A%94-%EC%9D%B4%EC%9C%A0

@dbswl701 dbswl701 dismissed stale reviews from lee1nna and clyde-yoonjae via bab603c March 14, 2025 14:20
@github-actions
Copy link

CI Status Report

검사 결과

  • Lint: ✅ success
  • Format: ✅ success
  • Type Check: ✅ success
  • Tests: ✅ success
  • Build: ✅ success

✅ 모든 검사가 통과되었습니다.

@dbswl701 dbswl701 merged commit b47f33c into dev Mar 14, 2025
8 checks passed
@dbswl701 dbswl701 deleted the feat/refactor/detail-modal/DEVING-80 branch March 14, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants