-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/setting/DEVING-8 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feat/setting/jest-rtl/DEVING-26
β¦t/DEVING-30 Feat/setting/codecov coderabbit/οΏ½DEVING-30
β¦VING-31 Feat/setting/eslint setting/DEVING-31
β¦EVING-14 Feat/setting/tailwind-config/DEVING-14
β¦DEVING-27 Feat/setting/folder structure/DEVING-27
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Walkthroughμ΄λ² PRμ μ¬λ¬ μ€μ λ° κ΅¬μ± νμΌμ λν μ λ°μ΄νΈμ μΆκ° ꡬμ±μ ν¬ν¨ν©λλ€. μλ‘μ΄ CI/CD μν¬νλ‘μ°, ESLint, Jest, Prettier, Tailwind CSS, tsconfig μ€μ λ±μ΄ μΆκ°Β·μμ λμμΌλ©°, ν μ€νΈ μ½λ λ° μ νΈλ¦¬ν° ν¨μκ° λμ λμμ΅λλ€. λν, λ¬Έμ(README.md) νμΌμ μ κ· μΉμ μ΄ μΆκ°λκ³ , νμΌ κ΅¬μ‘° μΌλΆκ° λ³κ²½λμμ΅λλ€. Changes
Sequence Diagram(s)sequenceDiagram
participant PR as "Pull Request"
participant GHA as "GitHub Actions (PR Check)"
participant Checkout as "μ½λ 체ν¬μμ"
participant Node as "Node.js μ€μ (v18)"
participant Steps as "체ν¬: λ¦°νΈ, ν¬λ§·, νμ
, ν
μ€νΈ, λΉλ"
participant Coverage as "Codecov μ
λ‘λ"
participant Comment as "μν 리ν¬νΈ"
PR->>GHA: PR μ΄λ²€νΈ λ°μ (opened, synchronized, reopened)
GHA->>Checkout: μ μ₯μ 체ν¬μμ
Checkout->>Node: Node.js μ€μ
Node->>Steps: μ½λ κ²μ¬ λ° μ€ν
Steps->>Coverage: 컀λ²λ¦¬μ§ μ
λ‘λ
Coverage->>Comment: κ²°κ³Ό μ½λ©νΈ μμ±
Comment->>PR: PRμ μν 보κ³
sequenceDiagram
participant PR as "Pull Request"
participant Labeler as "GitHub Actions (PR Labeler)"
participant Commits as "μ»€λ° λͺ©λ‘ μ‘°ν"
participant Script as "μ»€λ° λ©μμ§ μ²λ¦¬"
participant API as "GitHub API"
PR->>Labeler: PR μ΄λ²€νΈ λ°μ (opened, edited)
Labeler->>Commits: μ»€λ° μ‘°ν
Commits->>Script: λ©μμ§ λΆμ
Script->>API: λΌλ²¨ μ μ© μμ²
Possibly related PRs
Suggested labels
Suggested reviewers
β¨ Finishing Touches
πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
μΈν λμΌμΌμ μκ³ ν΄μ½μλ€ |
CI Status Reportκ²μ¬ κ²°κ³Ό
β λͺ¨λ κ²μ¬κ° ν΅κ³Όλμμ΅λλ€. |
Lee-Dong-Seok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
κ³ μνμ ¨μ΅λλ€!!
Codecov ReportAll modified and coverable lines are covered by tests β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
π§Ή Nitpick comments (17)
src/service/api/endpoints.ts (1)
3-5: μλν¬μΈνΈ νμ μμ μ± κ°μ μ΄ νμν©λλ€.νμ¬ κ΅¬νμ κΈ°λ³Έμ μΈ νμ μμ μ±μ μ 곡νμ§λ§, λ κ°λ ₯ν νμ 체ν¬μ μλμμ±μ μν΄ κ°μ μ΄ νμν©λλ€.
λ€μκ³Ό κ°μ΄ νμ μ μλ₯Ό μΆκ°νλ κ²μ μ μλ립λλ€:
+type EndpointKeys = 'TEST'; + +type Endpoints = { + readonly [K in EndpointKeys]: string; +}; + -export const ENDPOINTS = { +export const ENDPOINTS: Endpoints = { TEST: `${API_BASE_URL}/test`, } as const;μ΄λ κ² νλ©΄:
- μλν¬μΈνΈ ν€μ νμ μμ μ± ν보
- μλμμ± κΈ°λ₯ κ°ν
- μ€μλ‘ μΈν μ€ν λ°©μ§
__tests__/add.test.ts (1)
1-5: ν μ€νΈ μΌμ΄μ€ μΆκ° μ μκΈ°λ³Έμ μΈ ν μ€νΈ μΌμ΄μ€κ° μ μμ±λμ΄ μμ΅λλ€. νμ§λ§ ν¨μμ μ λ’°μ±μ λμ΄κΈ° μν΄ λ€μκ³Ό κ°μ μΆκ° ν μ€νΈ μΌμ΄μ€λ₯Ό κ³ λ €ν΄λ³΄μκΈ° λ°λλλ€:
- μμ κ° ν μ€νΈ
- 0κ³Όμ λ§μ ν μ€νΈ
- ν° μ«μ ν μ€νΈ
- μμμ ν μ€νΈ
test('μμ ν μ€νΈ', () => { expect(add(-2, -3)).toBe(-5); }); test('0 ν μ€νΈ', () => { expect(add(0, 5)).toBe(5); }); test('ν° μ«μ ν μ€νΈ', () => { expect(add(999999, 1)).toBe(1000000); }); test('μμμ ν μ€νΈ', () => { expect(add(0.1, 0.2)).toBeCloseTo(0.3); });src/util/add.ts (1)
1-3: μ λ ₯ κ° κ²μ¦ μΆκ° μ μνμ¬ κ΅¬νμ μ ννμ§λ§, λ μμ μ μΈ ν¨μλ₯Ό μν΄ μ λ ₯ κ° κ²μ¦μ μΆκ°νλ κ²μ κ³ λ €ν΄λ³΄μΈμ.
const add = (a: number, b: number): number => { if (!Number.isFinite(a) || !Number.isFinite(b)) { throw new Error('μ ν¨νμ§ μμ μ λ ₯μ λλ€. μ νν μ«μλ§ νμ©λ©λλ€.'); } return a + b; };jest.setup.ts (1)
3-7: μ½μ μλ¬ μ²λ¦¬ κ°μ μ μνμ¬ κ΅¬νλ μ½μ μλ¬ μ²λ¦¬λ μλνμ§λ§, λ€μκ³Ό κ°μ κ°μ μ¬νμ κ³ λ €ν΄λ³΄μΈμ:
- νμ μ 보 μΆκ°
- λ ꡬ체μ μΈ μλ¬ λ©μμ§ νν°λ§
- μλ³Έ μλ¬ λ‘κΉ μ μ§
const originalError = console.error; jest.spyOn(console, 'error').mockImplementation((message: string, ...args: any[]) => { if (message.includes('fetchPriority')) { return; } // λ€λ₯Έ μλ¬λ μ μμ μΌλ‘ λ‘κΉ originalError.call(console, message, ...args); });src/app/test/page.tsx (1)
1-8: μ κ·Όμ± λ° μλ§¨ν± λ§ν¬μ κ°μ μ μμ»΄ν¬λνΈκ° μ ꡬνλμ΄ μμ§λ§, λ€μκ³Ό κ°μ κ°μ μ¬νμ κ³ λ €ν΄λ³΄μΈμ:
- μλ§¨ν± HTML μμ μ¬μ©
- μ κ·Όμ± μμ± μΆκ°
- νμ΄μ§ μ λͺ© μΆκ°
function TestPage() { return ( <main> <h1>ν μ€νΈ νμ΄μ§</h1> <section aria-label="ν μ€νΈ νμ΄μ§ μ€λͺ "> <p> ν μ€νΈ νμ΄μ§ μ λλ€. νμ΄μ§μμ μλ³νκΈ° μν΄ μ λ―Έμ¬λ‘ Pageλ₯Ό λΆμ λλ€. νμ΄μ§ μ»΄ν¬λνΈλ ν¨μ μ μΈλ¬Έμ μ¬μ©ν©λλ€. </p> </section> </main> ); }jest.config.ts (1)
10-22: μ½λ 컀λ²λ¦¬μ§ μκ³κ° μ€μ μ μΆκ°νλ κ²μ΄ μ’μ΅λλ€.ν μ€νΈ 컀λ²λ¦¬μ§ νμ§μ 보μ₯νκΈ° μν΄ λ€μκ³Ό κ°μ μ€μ μ μΆκ°νλ κ²μ μ μν©λλ€:
const config: Config = { coverageProvider: 'v8', + coverageThreshold: { + global: { + branches: 80, + functions: 80, + lines: 80, + statements: 80 + } + }, testEnvironment: 'jsdom',eslint.config.mjs (1)
47-47: κ·μΉμ λν μ€λͺ μ£Όμ μΆκ°κ° νμν©λλ€.κ° ESLint κ·μΉμ λν μ€λͺ μ£Όμμ μΆκ°νλ©΄ νμλ€μ μ΄ν΄λ₯Ό λμΈ μ μμ΅λλ€.
rules: { + // JSX κΈ°λ₯ νμ±ν ecmaFeatures: { jsx: true }, + // μ¬μ©νμ§ μλ λ³μ κ·μΉ μ€μ '@typescript-eslint/no-unused-vars': ['warn', { args: 'after-used', varsIgnorePattern: '^_' }], + // labelκ³Ό form control μ°κ²° κ·μΉ 'jsx-a11y/label-has-associated-control': ['error', { required: { some: ['nesting', 'id'] } }], + // React λ²μ μλ κ°μ§ settings: { react: { version: 'detect' } }, + // μ μΈ μ μ¬μ© κ·μΉ λΉνμ±ν (React μ»΄ν¬λνΈμ©) '@typescript-eslint/no-use-before-define': 'off', }Also applies to: 66-66, 70-70, 77-77, 81-81
.github/pull_request_template.md (1)
1-20: PR ν νλ¦Ώ κ°μ μ μν μ μμ¬νμ΄ μμ΅λλ€.ν νλ¦Ώμ΄ μ ꡬμ±λμ΄ μμ§λ§, λ€μκ³Ό κ°μ κ°μ μ¬νμ μ μν©λλ€:
## π μ£Όμ μμ λ΄μ© -ex) λ³ΈμΈμ΄ μμ±ν λ΄μ©μ λν μμΈ μ€λͺ +ex) μμ ν λ΄μ©μ λν΄ μμΈν μ€λͺ ν΄ μ£ΌμΈμ. +- [ ] κΈ°λ₯ 1 +- [ ] κΈ°λ₯ 2 ## πΊ μ€ν¬λ¦°μ· -(μ νμ¬ν) +UI λ³κ²½μ¬νμ΄ μλ κ²½μ° μ€ν¬λ¦°μ·μ 첨λΆν΄ μ£ΌμΈμ. (μ νμ¬ν) ## π μ°Έκ³ μ¬ν -ex) μλ Όν μ , 리뷰μ΄κ° μ νμκ° μλ μΆκ° μ 보λ λ¬Έμ, μ°Έκ³ λ§ν¬λ₯Ό ν¬ν¨. +ex) 리뷰μ΄κ° μμμΌ ν λ΄μ©μ μμ±ν΄ μ£ΌμΈμ: +- μλ Όν μ +- μΆκ° μ 보λ λ¬Έμ +- μ°Έκ³ λ§ν¬ ## π¬ 리뷰 μꡬμ¬ν -ex) μ€μ μ μΌλ‘ 리뷰ν΄μ€¬μΌλ©΄ νλ λΆλΆ +ex) λ€μ λΆλΆλ€μ μ€μ μ μΌλ‘ λ¦¬λ·°ν΄ μ£Όμλ©΄ κ°μ¬νκ² μ΅λλ€: +- [ ] μ½λ ꡬ쑰 +- [ ] μ±λ₯ +- [ ] 보μ ## π κ΄λ ¨ μ΄μ -ex) #μ΄μ λ²νΈ +ex) Closes #μ΄μλ²νΈ.coderabbit.yml (1)
1-16: CodeRabbit μ€μ μ 보μνλ©΄ μ’μ κ² κ°μ΅λλ€.νμ¬ μ€μ μ μ ν¨νμ§λ§, λ€μκ³Ό κ°μ μΆκ° μ€μ μ κ³ λ €ν΄ λ³΄μΈμ:
language: 'ko-KR' early_access: false reviews: profile: 'chill' request_changes_workflow: false high_level_summary: true poem: false allowed_branches: ['*'] review_status: true collapse_walkthrough: false auto_review: enabled: true drafts: false + labels: [] # μλ 리뷰λ₯Ό μν λΌλ²¨ μ€μ + tools: + eslint: + enabled: true # ESLint ν΅ν© νμ±ν + markdownlint: + enabled: true # λ§ν¬λ€μ΄ λ¦°νΈ νμ±ν chat: auto_reply: truesrc/types/README.md (2)
1-3: λ¬Έμ νμμ κ°μ ν΄ μ£ΌμΈμ.λ§ν¬λ€μ΄ ν€λ©μμλ λ§μΉ¨νλ₯Ό μ κ±°νλ κ²μ΄ μ’μ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
## types ν΄λ -### μ μμΌλ‘ μ¬μ©λ νμ μ λͺ¨μλλ ν΄λμ λλ€. +### μ μμΌλ‘ μ¬μ©λ νμ μ λͺ¨μλλ ν΄λπ§° Tools
πͺ markdownlint-cli2 (0.17.2)
3-3: Trailing punctuation in heading
Punctuation: '.'(MD026, no-trailing-punctuation)
1-3: νμ ν΄λμ λν μ€λͺ μ 보μν΄ μ£ΌμΈμ.νμ¬ μ€λͺ μ΄ λ§€μ° κ°λ¨ν©λλ€. λ€μκ³Ό κ°μ λ΄μ©μ μΆκ°νλ©΄ μ’μ κ² κ°μ΅λλ€:
- νμ μ μ λ°©μκ³Ό λ€μ΄λ° 컨벀μ
- μ£Όμ νμ μΉ΄ν κ³ λ¦¬ μ€λͺ
- νμ μ¬μ¬μ© κ°μ΄λλΌμΈ
π§° Tools
πͺ markdownlint-cli2 (0.17.2)
3-3: Trailing punctuation in heading
Punctuation: '.'(MD026, no-trailing-punctuation)
src/util/README.md (2)
1-3: λ¬Έμ νμμ κ°μ ν΄ μ£ΌμΈμ.λ§ν¬λ€μ΄ ν€λ©μμλ λ§μΉ¨νλ₯Ό μ κ±°νλ κ²μ΄ μ’μ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
## util ν΄λ -### νλ‘μ νΈμμ μ¬μ¬μ©λλ μ νΈλ¦¬ν° ν¨μλ€μ λͺ¨μλλ ν΄λμ λλ€. +### νλ‘μ νΈμμ μ¬μ¬μ©λλ μ νΈλ¦¬ν° ν¨μλ€μ λͺ¨μλλ ν΄λπ§° Tools
πͺ markdownlint-cli2 (0.17.2)
3-3: Trailing punctuation in heading
Punctuation: '.'(MD026, no-trailing-punctuation)
5-5: μ νΈλ¦¬ν° ν¨μ μμλ₯Ό μΆκ°ν΄ μ£ΌμΈμ.κ° μ νΈλ¦¬ν° νμ (λ¬Έμμ΄ ν¬λ§·ν , λ μ§μ²λ¦¬, κ³΅ν΅ ν¬νΌ ν¨μ)μ λν ꡬ체μ μΈ μμμ μ¬μ©λ²μ μΆκ°νλ©΄ μ’μ κ² κ°μ΅λλ€.
src/lib/README.md (2)
1-3: λ¬Έμ νμμ κ°μ ν΄ μ£ΌμΈμ.λ§ν¬λ€μ΄ ν€λ©μμλ λ§μΉ¨νλ₯Ό μ κ±°νλ κ²μ΄ μ’μ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
## lib ν΄λ -### μΈλΆ λΌμ΄λΈλ¬λ¦¬ μ°λ μ½λ λ° λ‘μ§μ λͺ¨μλλ ν΄λμ λλ€. +### μΈλΆ λΌμ΄λΈλ¬λ¦¬ μ°λ μ½λ λ° λ‘μ§μ λͺ¨μλλ ν΄λπ§° Tools
πͺ markdownlint-cli2 (0.17.2)
3-3: Trailing punctuation in heading
Punctuation: '.'(MD026, no-trailing-punctuation)
5-5: λ§ν¬λ€μ΄ λ¬Έλ²μ μΌκ΄λκ² μ¬μ©ν΄ μ£ΌμΈμ.HTML νκ·Έ(
<br/>) λμ λ§ν¬λ€μ΄μ μ€λ°κΏ λ¬Έλ²μ μ¬μ©νλ κ²μ΄ μ’μ΅λλ€.λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
-axios, react-query κ°μ μλνν° λΌμ΄λΈλ¬λ¦¬ μ΄κΈ°ν λ±μ μ μν©λλ€. <br/> +axios, react-query κ°μ μλνν° λΌμ΄λΈλ¬λ¦¬ μ΄κΈ°ν λ±μ μ μν©λλ€.src/hooks/README.md (2)
1-3: λ¬Έμ νμμ κ°μ ν΄ μ£ΌμΈμ.λ§ν¬λ€μ΄ ν€λ©μμλ λ§μΉ¨νλ₯Ό μ κ±°νλ κ²μ΄ μ’μ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
## hooks ν΄λ -### 컀μ€ν ν μ μ μνλ ν΄λμ λλ€. +### 컀μ€ν ν μ μ μνλ ν΄λπ§° Tools
πͺ markdownlint-cli2 (0.17.2)
3-3: Trailing punctuation in heading
Punctuation: '.'(MD026, no-trailing-punctuation)
5-7: μ€νλ₯Ό μμ νκ³ λ§ν¬λ€μ΄ λ¬Έλ²μ μΌκ΄λκ² μ¬μ©ν΄ μ£ΌμΈμ.
- 'useQuries'λ₯Ό 'useQueries'λ‘ μμ ν΄ μ£ΌμΈμ.
- HTML νκ·Έ(
<br/>) λμ λ§ν¬λ€μ΄μ μ€λ°κΏ λ¬Έλ²μ μ¬μ©ν΄ μ£ΌμΈμ.λ€μκ³Ό κ°μ΄ μμ ν΄ μ£ΌμΈμ:
-common ν΄λμλ μ μμμ μ¬μ©ν 컀μ€ν ν λ€μ μ μν©λλ€.<br/> -queries ν΄λμλ tanstack-queryμ useQuriesλ₯Ό μ¬μ©ν 컀μ€ν ν λ€μ μ μν©λλ€.<br/> +common ν΄λμλ μ μμμ μ¬μ©ν 컀μ€ν ν λ€μ μ μν©λλ€. + +queries ν΄λμλ tanstack-queryμ useQueriesλ₯Ό μ¬μ©ν 컀μ€ν ν λ€μ μ μν©λλ€.
π Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/assets/icon/favicon.icois excluded by!**/*.ico
π Files selected for processing (31)
.coderabbit.yml(1 hunks).github/pull_request_template.md(1 hunks).github/workflows/pr-check.yml(1 hunks).github/workflows/pr-labeler.yml(1 hunks).prettierrc(1 hunks)__tests__/add.test.ts(1 hunks)eslint.config.mjs(3 hunks)jest.config.ts(1 hunks)jest.setup.ts(1 hunks)package.json(2 hunks)postcss.config.js(1 hunks)postcss.config.mjs(0 hunks)src/app/globals.css(0 hunks)src/app/layout.tsx(1 hunks)src/app/page.tsx(4 hunks)src/app/test/components/TestComponent.tsx(1 hunks)src/app/test/page.tsx(1 hunks)src/assets/README.md(1 hunks)src/components/README.md(1 hunks)src/hooks/README.md(1 hunks)src/lib/README.md(1 hunks)src/service/README.md(1 hunks)src/service/api/endpoints.ts(1 hunks)src/store/README.md(1 hunks)src/styles/README.md(1 hunks)src/styles/globals.css(1 hunks)src/types/README.md(1 hunks)src/util/README.md(1 hunks)src/util/add.ts(1 hunks)tailwind.config.ts(1 hunks)tsconfig.json(2 hunks)
π€ Files with no reviewable changes (2)
- src/app/globals.css
- postcss.config.mjs
β Files skipped from review due to trivial changes (9)
- src/assets/README.md
- postcss.config.js
- src/styles/globals.css
- src/app/test/components/TestComponent.tsx
- src/styles/README.md
- src/service/README.md
- src/store/README.md
- src/components/README.md
- src/app/page.tsx
π§° Additional context used
πͺ actionlint (1.7.4)
.github/workflows/pr-check.yml
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
19-19: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
49-49: the runner of "codecov/codecov-action@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
60-60: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/pr-labeler.yml
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
18-18: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
πͺ YAMLlint (1.35.1)
.github/workflows/pr-labeler.yml
[error] 32-32: trailing spaces
(trailing-spaces)
πͺ ESLint
src/app/layout.tsx
[error] 2-2: Insert β
(prettier/prettier)
πͺ markdownlint-cli2 (0.17.2)
src/hooks/README.md
3-3: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
src/lib/README.md
3-3: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
src/types/README.md
3-3: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
src/util/README.md
3-3: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: check
π Additional comments (12)
src/app/layout.tsx (1)
2-2: κΈλ‘λ² μ€νμΌ νμΌ μμΉ λ³κ²½μ΄ μ μ ν©λλ€.μ€νμΌ νμΌμ
src/stylesλλ ν λ¦¬λ‘ μ΄λν κ²μ Next.js νλ‘μ νΈμ μΌλ°μ μΈ κ΅¬μ‘°λ₯Ό λ°λ₯΄λ μ’μ λ³κ²½μ λλ€. μ΄λ μ€νμΌ κ΄λ ¨ νμΌλ€μ ν κ³³μμ κ΄λ¦¬ν μ μκ² ν΄μ€λλ€.π§° Tools
πͺ ESLint
[error] 2-2: Insert
β(prettier/prettier)
tailwind.config.ts (1)
1-8: LGTM!μ€μ μ΄ λͺ ννκ³ μ μ νκ² κ΅¬μ±λμ΄ μμ΅λλ€.
jest.config.ts (2)
1-8: μ€μ μ΄ μ¬λ°λ₯΄κ² ꡬμ±λμμ΅λλ€!Next.js ν μ€νΈ νκ²½μ΄ μ μ νκ² μ€μ λμμ΅λλ€.
24-25: λ΄λ³΄λ΄κΈ°κ° μ¬λ°λ₯΄κ² ꡬνλμμ΅λλ€!λΉλκΈ° μ€μ μ μν μ μ ν λ΄λ³΄λ΄κΈ° λ°©μμ λλ€.
eslint.config.mjs (1)
19-29:Details
β Verification inconclusive
무μν νμΌ λͺ©λ‘μ΄ μ μ νμ§ νμΈμ΄ νμν©λλ€.
**/*.jsλ₯Ό 무μνλ κ²μ΄ μλμ μΈμ§ νμΈν΄ μ£ΌμΈμ. TypeScript νλ‘μ νΈμμλ μΌλΆ JavaScript νμΌμ νμν μ μμ΅λλ€.
π Script executed:
#!/bin/bash # JavaScript νμΌ μ¬μ© νν© νμΈ echo "Repositoryμμ μ¬μ© μ€μΈ JavaScript νμΌ λͺ©λ‘:" fd -e js --type fLength of output: 120
νμΈ μμ²: 무μν νμΌ μ€μ κ²ν
νμ¬ λ¦¬ν¬μ§ν 리μμ JavaScript νμΌμ
postcss.config.jsνλλ§ μ‘΄μ¬νλ κ²μΌλ‘ νμΈλμμ΅λλ€.
- λ§μ½
postcss.config.jsλ lint κ²μ¬λ₯Ό λ°μμΌ νλ€λ©΄,**/*.jsλ‘ λͺ¨λ JavaScript νμΌμ 무μνλ μ€μ μ μ¬κ²ν νμ¬ ν΄λΉ νμΌμ΄ lint λμμ ν¬ν¨λλλ‘ μμ ν΄ μ£ΌμΈμ.- λ°λλ‘
postcss.config.jsλ₯Ό lint λμμμ μ μΈνλ κ²μ΄ μλν κ²μ΄λΌλ©΄, νμ¬ ignore μ€μ μ λ¬Έμ κ° μμ΄ λ³΄μ λλ€..prettierrc (2)
10-13: νλ¬κ·ΈμΈ ꡬμ±μ΄ μ μ ν©λλ€!Prettierμ Tailwind CSS, κ·Έλ¦¬κ³ import μ λ ¬μ μν νλ¬κ·ΈμΈμ΄ μ ꡬμ±λμ΄ μμ΅λλ€.
14-25: import μμκ° μ μ μλμ΄ μμ΅λλ€.κ° μΉ΄ν κ³ λ¦¬λ³λ‘ import μμκ° λͺ ννκ² μ μλμ΄ μμ΄ μ½λμ μΌκ΄μ±μ μ μ§νλ λ° λμμ΄ λ κ² κ°μ΅λλ€.
tsconfig.json (2)
5-5: Jest νμ μΆκ°κ° μ μ ν©λλ€.ν μ€νΈ νκ²½ μ€μ μ μν Jest νμ μ΄ μ μΆκ°λμμ΅λλ€.
22-32:Details
β Verification successful
κ²½λ‘ λ§€ν κ²μ¦μ΄ νμν©λλ€.
baseUrlκ³Όpathsμ€μ μ΄ μΆκ°λμμ΅λλ€. νλ‘μ νΈ κ΅¬μ‘°μ μΌμΉνλμ§ νμΈμ΄ νμν©λλ€.
π Script executed:
#!/bin/bash # src λλ ν 리 ꡬ쑰 νμΈ fd --type d --max-depth 1 . srcLength of output: 147
κ²½λ‘ λ§€ν μ€μ κ²μ¦ μλ£ β νλ‘μ νΈ κ΅¬μ‘°μ μΌμΉν©λλ€
"baseUrl": "./src"κ° μ¬λ°λ₯΄κ² μ§μ λμ΄ μμΌλ©°,- λͺ μμ μΈ κ²½λ‘ λ§€ν(
@/app/*,@/components/*,@/hooks/*,@/lib/*,@/styles/*,@/util/*,@/assets/*)μ μ€μ srcλλ ν 리 λ΄ ν΄λΉ ν΄λλ€κ³Ό μΌμΉν©λλ€.- μΆκ° λλ ν 리μΈ
service,store,typesλ"@/*": ["/*"]catch-all ν¨ν΄μ ν΅ν΄ μ κ·Ό κ°λ₯νλ―λ‘ λ³λ λ§€νμ΄ νμνμ§ μμ 보μ λλ€.- μ°Έκ³ λ‘, catch-all μ€μ μ κ²½μ°
"/*"λμ"*"λ₯Ό μ¬μ©νλ©΄ λ€λ₯Έ λ§€νκ³Όμ μΌκ΄μ± λ©΄μμ λ κΉλν μ μμΌλ κ²ν ν΄λ³΄μκΈ° λ°λλλ€.package.json (1)
13-13: ν μ€νΈ 컀λ²λ¦¬μ§ μ€μ μ΄ μ λμ΄μμ΅λλ€.Jestλ₯Ό μ¬μ©ν ν μ€νΈ 컀λ²λ¦¬μ§ μμ§μ΄ μ ꡬμ±λμ΄ μμ΅λλ€.
.github/workflows/pr-labeler.yml (1)
31-31: μ»€λ° λ©μμ§ μ κ·μμ΄ μ μ μλμ΄ μμ΅λλ€.μ»€λ° νμ μ μ ννκ² κ΅¬λΆν μ μλ μ κ·μμ΄ μ μμ±λμ΄ μμ΅λλ€.
.github/workflows/pr-check.yml (1)
73-80: CI μν 리ν¬νΈκ° μ ꡬμ±λμ΄ μμ΅λλ€.κ° λ¨κ³λ³ κ²μ¬ κ²°κ³Όλ₯Ό μ΄λͺ¨μ§μ ν¨κ» λͺ ννκ² νμνκ³ μμ΄ κ°λ μ±μ΄ μ’μ΅λλ€.
| @@ -0,0 +1,5 @@ | |||
| export const API_BASE_URL = 'http://3.34.218.217:8080/'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
νλμ½λ©λ IP μ£Όμλ₯Ό νκ²½ λ³μλ‘ μ΄λνμΈμ.
νλ‘λμ μ½λμ IP μ£Όμλ₯Ό μ§μ νλμ½λ©νλ κ²μ λ€μκ³Ό κ°μ λ¬Έμ λ₯Ό μΌκΈ°ν μ μμ΅λλ€:
- νκ²½(κ°λ°/μ€ν μ΄μ§/νλ‘λμ )λ³ μ€μ κ΄λ¦¬μ μ΄λ €μ
- 보μ μ·¨μ½μ λ°μ κ°λ₯μ±
- μ½λ μ μ§λ³΄μμ μ΄λ €μ
λ€μκ³Ό κ°μ΄ νκ²½ λ³μλ₯Ό μ¬μ©νλλ‘ μμ νλ κ²μ κΆμ₯λ립λλ€:
-export const API_BASE_URL = 'http://3.34.218.217:8080/';
+export const API_BASE_URL = process.env.NEXT_PUBLIC_API_BASE_URL || 'http://localhost:8080/';μΆκ°λ‘ .env νμΌμ μμ±νμ¬ νκ²½ λ³μλ₯Ό κ΄λ¦¬νμΈμ:
// .env.development
NEXT_PUBLIC_API_BASE_URL=http://dev-api.example.com
// .env.production
NEXT_PUBLIC_API_BASE_URL=http://api.example.com| @@ -1,5 +1,5 @@ | |||
| import type { Metadata } from 'next'; | |||
| import './globals.css'; | |||
| import '../styles/globals.css'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
μ½λ ν¬λ§·ν μμ μ΄ νμν©λλ€.
ESLintκ° import λ¬Έ λ€μ κ°νμ΄ νμνλ€κ³ μ§μ νκ³ μμ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄μ£ΌμΈμ:
import type { Metadata } from 'next';
-import '../styles/globals.css';
+import '../styles/globals.css';
+π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import '../styles/globals.css'; | |
| import type { Metadata } from 'next'; | |
| import '../styles/globals.css'; | |
π§° Tools
πͺ ESLint
[error] 2-2: Insert β
(prettier/prettier)
| main: '#525FEE', | ||
| default: '#C2C9FF', | ||
| solid: '#E5e7fa', | ||
| disable: '#30333e', | ||
| disable_text: '#4a4e5e', | ||
| Cgray500: '#626675', | ||
| Cgray400: '#424655', | ||
| Cgray300: '#30333E', | ||
| Cgray200: '#22242B', | ||
| Cgray100: '#1B1D21', | ||
| white: '#FFFFFF', | ||
| black: '#000000', | ||
| warning: '#Fb3b49', | ||
| clear: '#00c48c', | ||
| Cgray700: '#B4BBCE', | ||
| Cgray800: '#D8DEE8', | ||
| BG: '#121212', | ||
| BG_2: '1B1B1D', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
μμ μ μμμ κ°μ μ΄ νμν λΆλΆμ΄ μμ΅λλ€.
λ€μκ³Ό κ°μ λ¬Έμ μ λ€μ΄ λ°κ²¬λμμ΅λλ€:
- μμ μ΄λ¦μ΄ μΌκ΄μ±μ΄ μμ΅λλ€ (μ:
Cgray500μdisable_text). BG_2μμ κ°μ '#' μ λμ¬κ° λλ½λμμ΅λλ€.- μΌλΆ μμμ μλ―Έλ‘ μ μ΄λ¦μ μ¬μ©νλ©΄ λ λͺ νν κ² κ°μ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ νλ κ²μ μ μλ립λλ€:
colors: {
- main: '#525FEE',
- default: '#C2C9FF',
- solid: '#E5e7fa',
- disable: '#30333e',
- disable_text: '#4a4e5e',
- Cgray500: '#626675',
- Cgray400: '#424655',
- Cgray300: '#30333E',
- Cgray200: '#22242B',
- Cgray100: '#1B1D21',
+ primary: '#525FEE',
+ secondary: '#C2C9FF',
+ tertiary: '#E5e7fa',
+ disabled: '#30333e',
+ disabledText: '#4a4e5e',
+ gray500: '#626675',
+ gray400: '#424655',
+ gray300: '#30333E',
+ gray200: '#22242B',
+ gray100: '#1B1D21',
white: '#FFFFFF',
black: '#000000',
- warning: '#Fb3b49',
- clear: '#00c48c',
- Cgray700: '#B4BBCE',
- Cgray800: '#D8DEE8',
+ error: '#Fb3b49',
+ success: '#00c48c',
+ gray700: '#B4BBCE',
+ gray800: '#D8DEE8',
BG: '#121212',
- BG_2: '1B1B1D',
+ BG2: '#1B1B1D',
},π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| main: '#525FEE', | |
| default: '#C2C9FF', | |
| solid: '#E5e7fa', | |
| disable: '#30333e', | |
| disable_text: '#4a4e5e', | |
| Cgray500: '#626675', | |
| Cgray400: '#424655', | |
| Cgray300: '#30333E', | |
| Cgray200: '#22242B', | |
| Cgray100: '#1B1D21', | |
| white: '#FFFFFF', | |
| black: '#000000', | |
| warning: '#Fb3b49', | |
| clear: '#00c48c', | |
| Cgray700: '#B4BBCE', | |
| Cgray800: '#D8DEE8', | |
| BG: '#121212', | |
| BG_2: '1B1B1D', | |
| colors: { | |
| primary: '#525FEE', | |
| secondary: '#C2C9FF', | |
| tertiary: '#E5e7fa', | |
| disabled: '#30333e', | |
| disabledText: '#4a4e5e', | |
| gray500: '#626675', | |
| gray400: '#424655', | |
| gray300: '#30333E', | |
| gray200: '#22242B', | |
| gray100: '#1B1D21', | |
| white: '#FFFFFF', | |
| black: '#000000', | |
| error: '#Fb3b49', | |
| success: '#00c48c', | |
| gray700: '#B4BBCE', | |
| gray800: '#D8DEE8', | |
| BG: '#121212', | |
| BG2: '#1B1B1D', | |
| }, |
| "test": "jest --coverage" | ||
| }, | ||
| "dependencies": { | ||
| "autoprefixer": "^10.4.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ€λ³΅λ autoprefixer μμ‘΄μ±μ μ κ±°ν΄μ£ΌμΈμ.
autoprefixerκ° dependenciesμ devDependenciesμ μ€λ³΅ν΄μ λ±λ‘λμ΄ μμ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄μ£ΌμΈμ:
"dependencies": {
- "autoprefixer": "^10.4.20",
"next": "14.1.0",
...
}Also applies to: 33-33
| label: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions λ²μ μ λ°μ΄νΈκ° νμν©λλ€.
νμ¬ μ¬μ© μ€μΈ GitHub Actions λ²μ μ΄ μ€λλμμ΅λλ€. μ΅μ λ²μ μΌλ‘ μ λ°μ΄νΈκ° νμν©λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄μ£ΌμΈμ:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- uses: actions/github-script@v6
+ uses: actions/github-script@v7Also applies to: 18-18
π§° Tools
πͺ actionlint (1.7.4)
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions λ²μ μ λ°μ΄νΈκ° νμν©λλ€.
μ¬λ¬ GitHub Actionsμ λ²μ μ΄ μ€λλμμ΅λλ€. μ΅μ λ²μ μΌλ‘ μ λ°μ΄νΈκ° νμν©λλ€.
λ€μκ³Ό κ°μ΄ μμ ν΄μ£ΌμΈμ:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
- uses: codecov/codecov-action@v3
+ uses: codecov/codecov-action@v4
- uses: actions/github-script@v6
+ uses: actions/github-script@v7Also applies to: 19-19, 49-49, 60-60
π§° Tools
πͺ actionlint (1.7.4)
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
π― PR λ΄μ©
setting μν½μ λ΄μ© dev λΈλμΉλ‘ λ¨Έμ§
μμ λ΄μ©
setting μν½μ λ΄μ© dev λΈλμΉλ‘ λ¨Έμ§
κ΄λ ¨ μ΄μ
#DEVING-8
Summary by CodeRabbit
New Features
Chores