[core][Matrix][Tests] Upgrade Matrix & Tests #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR lays the groundwork for returning views in both the Matrix and NDArray types. It also implements full support for Matrix views. The design for returning view is described in the NuMojo enhancement proposal #279 Support for NDArray views will be completed in a subsequent PR. Currently test workflow is commented out. Since Mojo has removed the `test` command, we will use the `TestSuite` to run tests hereafter. The tests will be fixed in the follow up PR. --------- Co-authored-by: ZHU Yuhao 朱宇浩 <[email protected]>
Mojo has deprecated `mojo test` command as of the latest nightly. This PR adds support for using the `TestSuite` to run NuMojo tests and updates the GitHub workflows. --------- Co-authored-by: ZHU Yuhao 朱宇浩 <[email protected]>
# Description This pull request migrates the test infrastructure from using `mojo test` to `mojo run` with a new TestSuite-based approach. It also includes improvements to the Matrix class, including fixing buffer type handling, enhancing slicing/indexing methods, and refactoring cumsum/cumprod implementations. - Migrated all test files to use TestSuite.discover_tests pattern with main() functions - Temporarily renamed all Matrix `__getitem__` and `__setitem__` that return views to be `get()` and `set()` due to a Bug in Mojo which doesn't allow use setting arrays with views as arguments in `__setitem__`. A bug report has been made in Mojo repo which can be found [here](modular/modular#5545). - Currently, the default `__getitem__` and `__setitem__` will return copies. Use `get` and `set` to returns views for now till Mojo bug gets resolved. - Added more `__setitem__` and `set` methods with various arguments to improve setter of Matrix. - Improved cumsum/cumprod implementations to better handle C and F contiguous matrices - Changed Buffered trait methods to static for is_own_data() and is_ref_data() --------- Co-authored-by: ZHU Yuhao 朱宇浩 <[email protected]>
This PR replaces UnsafePointer with `LegacyUnsafePointer` and fixes import names for the UnsafePointer. This will enable use to temporarily use old pointer and push changes to GitHub before migrating to completely new `UnsafePointer` in the next PR.
forfudan
approved these changes
Nov 25, 2025
Collaborator
forfudan
left a comment
forfudan
left a comment
There was a problem hiding this comment.
Hey @shivasankarka, I am back from my holiday. Thanks for the updates! The change of test to test suite is quite a big step.
Collaborator
Author
Welcome back :). Yeah, it's quite a change, it's also a tad slow to run all tests. But it gives much better debugging information right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the PR commits below for full descriptions. In short, this PR enables Matrix to returns views now. It also upgrades the tests to use the latest Mojo
TestSuite. Finally, it upgrades NuMojo to use latest Mojo nightly. This will let us roll out a new NuMojo version right after modular releases Mojo 25.7.0.Notes:
OwnDataandRefDatamodel as described in early parts of [PROPOSAL] Creation of NDArray, Matrix views #279 . This new version will be added to NuMojo in the next PR to keep changes minimal ([core][Matrix] Implement full support for Matrix views #286)