Abstracted matrix to pixel out of gui. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new file: matrix_to_pixel.hpp. It contains all the logic to modify a pixel based on a draw function. gui will simply identify a draw function and tell the matrix_to_pixel to create the correct pixel based on this function. Then, gui will draw that pixel.
Put some methods in matrix_to_pixel in an anonymous namespace, which should make them private to that file.
|
pls merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new file: matrix_to_pixel.hpp. It contains all the logic to modify a pixel based on a draw function. gui will simply identify a draw function and tell the matrix_to_pixel to create the correct pixel based on this function. Then, gui will draw that pixel.