This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Conversation
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
anttibull
reviewed
Sep 27, 2022
| import classNames from 'classnames' | ||
|
|
||
| import styles from './Button.module.css' | ||
| // constants |
Collaborator
There was a problem hiding this comment.
Suggested change
| // constants |
| import { createButtonDriver, DriverType } from './Button.driver' | ||
| import styles from './Button.module.css' | ||
|
|
||
| describe('Button', () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| describe('Button', () => { | |
| describe('<Button />', () => { |
| @@ -0,0 +1 @@ | |||
| export {} | |||
| driver = createButtonDriver() | ||
| }) | ||
|
|
||
| describe('default button behavior', () => { |
Collaborator
There was a problem hiding this comment.
можна простіше
Suggested change
| describe('default button behavior', () => { | |
| describe('by default', () => { |
| }) | ||
| }) | ||
|
|
||
| describe('layout button behavior', () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| describe('layout button behavior', () => { | |
| describe('by default', () => { |
Comment on lines
+95
to
+96
| clickButton: () => | ||
| fireEvent.click(screen.getByTestId(ButtonDataHooks.Button)), |
Collaborator
There was a problem hiding this comment.
це треба перенести в when
| expect(buttonPrimary).toHaveClass(styles.outline) | ||
| }) | ||
|
|
||
| it('with custom ccolor', () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| it('with custom ccolor', () => { | |
| it('with custom color', () => { |
| expect(button).toHaveAttribute('disabled') | ||
| }) | ||
|
|
||
| it('should be disabled when loading, ', () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| it('should be disabled when loading, ', () => { | |
| it('should be disabled when loading', () => { |
| children: <span>Title</span>, | ||
| } | ||
|
|
||
| export const CustomColot = Template.bind({}) |
Collaborator
There was a problem hiding this comment.
Suggested change
| export const CustomColot = Template.bind({}) | |
| export const CustomColor = Template.bind({}) |
| import classNames from 'classnames' | ||
|
|
||
| import styles from './Button.module.css' | ||
| // constants |
Collaborator
There was a problem hiding this comment.
Suggested change
| // constants |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.