Open
Conversation
This was referenced Mar 2, 2026
Closed
realforest2001
requested changes
Mar 2, 2026
Comment on lines
+14
to
+15
| honorary = "Lord" | ||
| honorary_f = "Lady" |
Collaborator
There was a problem hiding this comment.
Suggested change
| honorary = "Lord" | |
| honorary_f = "Lady" | |
| honorary = "Baron" | |
| honorary_f = "Baroness" |
Comment on lines
+83
to
+84
| honorary = "Lord" | ||
| honorary_f = "Lady" |
Collaborator
There was a problem hiding this comment.
Suggested change
| honorary = "Lord" | |
| honorary_f = "Lady" | |
| honorary = "Baron" | |
| honorary_f = "Baroness" |
| /datum/action/cooldown/spell/undirected/list_target/convert_role/church/churchling, | ||
| /datum/action/cooldown/spell/undirected/call_bird/priest, | ||
| ) | ||
| honorary = "Vicar" |
Collaborator
There was a problem hiding this comment.
I'm wondering if this should be map dependant, as the Priest who names King/Queen or Emperor/Empress is unlikely to be just a Vicar.
| outfit = /datum/outfit/town_elder/hearth_acolyte | ||
| category_tags = list(CTAG_TOWN_ELDER) | ||
| allowed_patrons = ALL_TEMPLE_PATRONS | ||
| //honorary = "STUPID DUMB CLASS WHICH I HATE" |
Collaborator
There was a problem hiding this comment.
It's the best and you will love it unconditionally.
Comment on lines
+30
to
+31
| honorary = "Lord" | ||
| honorary_f = "Lady" |
Collaborator
There was a problem hiding this comment.
Should this check if Medicator? As they lose their nobility if they're a medicator.
| STATKEY_INT = 4, | ||
| STATKEY_PER = 3 | ||
| ) | ||
| honorary = "Councilor" |
Collaborator
There was a problem hiding this comment.
Suggested change
| honorary = "Councilor" | |
| honorary = "Councillor" |
Collaborator
Also that might need looking into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Moves all Titles into their own honorary variable instead of their real name. Titles are added to names when examined or looked at but are not their true name. This means to make King John and outlaw, you would actually make "John" an outlaw.
Some roles have received titles as well. Most royals get one now, as well as many others.
Why It's Good For The Game
Clarity, and better roleplay. Acknowledgement of titles.
Changelog
🆑
add: Honorary Titles
/:cl:
Pre-Merge Checklist