feat: ✨ add maintenance mode to node #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintenance mode allows node operators to run their nodes without them interacting with the rest of the network. This allows them to do manual changes to the file or forest storage in case of inconsistencies between what's on-chain vs the local state.
ffarall
requested changes
Mar 11, 2025
Comment on lines
222
to
225
| if self.maintenance_mode { | ||
| info!(target: LOG_TARGET, "🔒 Maintenance mode is enabled. Skipping message processing."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think we could allow commands being sent to the BlockchainService. Just in case we need that functionality while in maintenance.
Comment on lines
1299
to
1302
| if self.maintenance_mode { | ||
| info!(target: LOG_TARGET, "🔒 Maintenance mode is enabled. Skipping processing ofblock import #{}: {}", block_number, block_hash); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I would apply this boolean further up, to basically not include the block import and finality events in the queue. Cause this way it is still possible that the node will attempt some action in the initial sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance mode allows node operators to run their nodes without them interacting with the rest of the network. This allows them to do manual changes to the file or forest storage in case of inconsistencies between what's on-chain vs the local state.
TODO: