Refactor: actors derive subscribe helper #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undercover-cactus
approved these changes
Mar 13, 2025
| @@ -6,7 +6,7 @@ homepage = { workspace = true } | |||
| license = { workspace = true } | |||
| authors = { workspace = true } | |||
| repository = { workspace = true } | |||
| edition = { workspace = true } | |||
| edition = "2021" | |||
There was a problem hiding this comment.
Should we change this at the root instead ?
| task: UserSendsFileTask, | ||
| service: &self.blockchain, | ||
| spawner: &self.task_spawner, | ||
| context: self.clone(), |
There was a problem hiding this comment.
Would it be possible to avoid to clone here ? Can we hold a reference of the context ?
There was a problem hiding this comment.
Not really. Maybe we can wrap up it up in an Arc but this is generating the same code as before (we are cloning there too). The context in our case is StorageHubHandler which already contains either Arcs or handlers which contain Arc, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #391.
Add
subscribe_actor_event!helper macro to help with code readability (and allow for more boilerplate reduction in future PRs).