Conversation
Initialize a promise chain that will be used to serialize all read-modify-write operations on the events file. This prevents the race condition where concurrent webhook deliveries could overwrite each other's data. Refs #241
withEventLock chains the provided function onto the write queue, ensuring only one read-modify-write cycle runs at a time. The second argument to .then() ensures the queue continues even if a previous operation fails.
The read-modify-write cycle (loadEvents -> push -> saveEvents) is now serialized through the write queue. Concurrent webhook deliveries will execute their file operations one at a time, preventing the second write from overwriting events added by the first. Closes #241
Previously the catch argument (fn) would re-run the operation on failure. Now errors are logged and the queue continues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241