permit install into windows program files #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
force-pushed
the
windows-startup
branch
from
e798598
to
b7265dd
Compare
soloturn
changed the title
|
for the "cd" in the script - normally this should not be needed, as an app may folllow the xdg spec, and even use some library to make this easier, like https://github.com/dirs-dev/directories-jvm . |
soloturn
force-pushed
the
windows-startup
branch
from
b7265dd
to
2176bab
Compare
soloturn
force-pushed
the
windows-startup
branch
from
448d45e
to
196d923
Compare
BenjaminAmos
approved these changes
Oct 20, 2024
when installing terasology into program files, that dir is not writeable. starting up, terasology tries to create a folder in .local, which then fails. therefor, permit to start the application from a different directory, and let it anyway find its libraries via the classpath. a workaround, as the app should ideally know its location and other jarfiles without tinkering with the classpath. Co-authored-by: BenjaminAmos <[email protected]>
soloturn
force-pushed
the
windows-startup
branch
from
196d923
to
5d216ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when installing terasology into program files, that dir is not writeable. starting up, terasology tries to create a folder in .local, which then fails.
therefor, permit two things with this change. first, permit calling the windows bat script from a different directory. it then needs to find the library relative to the start script location, not to the location where the script is called from.
second, before starting java, change to home directory. ideally, terasology itself should find a proper path by default. but program files as run directory is in any case wrong, so change.
this is the same change which was used to upload to chocolatey.