Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _data folder to store author details #20

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

srishti-nema
Copy link
Contributor

Description

Changes proposed in this pull request:

-Added an _data folder to store the details of various authors of blog posts.
-Didn't have any particular details to start with, so I have just created a format.

Related Issues and PRs

Fixes #14

Mobile & Desktop Screenshots (If any UI changes)

@cseas
Copy link
Contributor

cseas commented Oct 16, 2019

@asdofindia Are all the author usernames and other data available somewhere at a single place so we can add them here to start with?

Does the Mozilla India Wordpress blog have a separate page that lists out all the authors like this?

@karx
Copy link
Contributor

karx commented Oct 16, 2019

@cseas I am in favour of approving this PR, and a similar one https://github.com/MozillaIndia/blog/pull/16/files with adding the base set of layouts and includes there.

This will get the ball rolling.

@asdofindia
Copy link
Contributor

@cseas, all the author names used in the _posts can be obtained by something like ack author: | uniq I think.

Then these author $name can be looked up on https://blog.mozillaindia.org/author/:name

That will give their full name. That is the only extra info publicly visible.

The dump of the blog also includes their email addresses, but I don't think we should add that to a public repository (neither is it required).

As to avatar, bio, etc we are starting fresh anyhow (as the old blog did not have these)

@asdofindia asdofindia merged commit 6b8c7f0 into MozillaIndia:master Oct 17, 2019
@asdofindia
Copy link
Contributor

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create data file to store information of authors
4 participants