Release 0.2.1: skip __pycache__ in template walker - #5
Merged
Conversation
Fresh installs hit a UnicodeDecodeError when iter_job_template_files tried to read .pyc files inside a __pycache__ directory as UTF-8 text. Filter ignored directory names and bytecode suffixes (.pyc/.pyo) before reading so vibeshed new succeeds even when bytecode has been generated under templates/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__pycache__directories and.pyc/.pyofiles in_walk_filessovibeshed newno longer crashes withUnicodeDecodeErrorwhen bytecode exists undertemplates/job_template/.0.2.0 → 0.2.1.Context
Reported by Riven on a fresh install: scaffold tried to read compiled
.pycbytecode as UTF-8 jinja templates and threwUnicodeDecodeError. This PR re-cuts the fix that was originally drafted asrelease/v0.1.3(#4, now closed) — it had to be rebased to0.2.1once0.1.2and0.2.0landed onmain.Test plan
pytest -ra(37 passed).pycheader +__pycache__and asserts the walker only yieldsmain.py🤖 Generated with Claude Code