Conversation
CRITAWAKETS
reviewed
Mar 2, 2026
| . = ..() | ||
| if(!.) | ||
| return | ||
| target_holder.add_reagent(/datum/reagent/perfume, round(seed.potency * pick(0.01, 0.02, 0.03), CHEMICAL_VOLUME_ROUNDING)) |
Contributor
There was a problem hiding this comment.
Shouldn't this just be a reagent gene? This feels way too snowflaked for my liking.
And yes, that would also allow making perfumes from any plant, which sounds funny. Eau de Gatfruit
Owner
Author
There was a problem hiding this comment.
I just wanted to get it in as a proof of concept where it can be expanded upon later, ie. different plants giving different scents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #886
I refactored a bit of the smell component to no longer rely on some hacky code
A fair bit was changed to make using the system easier
Double-examining an item emitting a smell indicates the smell is coming from it
Adds perfume to loadout, it's a spray bottle that contains 10u perfume reagent. When spraying perfume reagent on things, it makes them smell nice. You can refill the bottle by grinding poppies, lilies, or geraniums.
Cigerette smoke now lingers on the smoker and the cigarette, rather than only on the spot.
Putting out a cigarette in an ash tray causes it to smell of lingering smoke.
Blood should reach "overpowering" less often.
Fixes scents not being sorted by intensity
Objects no longer smell of cleaner after being cleaned. Turfs and mobs still do.