Support for regrowing KKTrack fits from KalSeed objects #1595
Conversation
…aw channel ID's is in place
module locations to keep them in sync with what's in crv_parameters.xlxs)
| auto ktrk = std::make_unique<KKTRK>(config_,*kkbf_,kseed.particle(),trajptr,strawhits,strawxings,calohits,domains); | ||
| if(ktrk && ktrk->fitStatus().usable()){ | ||
| if(debug_ > 0) std::cout << "RegrowLoopHelix: successful track refit" << std::endl; | ||
| // temporary test |
There was a problem hiding this comment.
Is this comment real, i.e. should the call to extendTrack be removed?
|
Good catch! that comment was old as I made extension a module option, but
the call to extend wasn't predicate on the fcl parameter, so this was an
error.
…On Tue, Oct 7, 2025 at 7:08 PM Ed Callaghan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Mu2eKinKal/src/RegrowLoopHelix_module.cc
<#1595 (comment)>:
> @@ -237,6 +245,8 @@ namespace mu2e {
auto ktrk = std::make_unique<KKTRK>(config_,*kkbf_,kseed.particle(),trajptr,strawhits,strawxings,calohits,domains);
if(ktrk && ktrk->fitStatus().usable()){
if(debug_ > 0) std::cout << "RegrowLoopHelix: successful track refit" << std::endl;
+// temporary test
Is this comment real, i.e. should the call to extendTrack be removed?
—
Reply to this email directly, view it on GitHub
<#1595 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAH57Z5G6FATTCIH2Y3ET33WRW3BAVCNFSM6AAAAACGI6KCA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJSGUZDIMJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
|
|
@FNALbuild run build test with Mu2e/mu2e-trig-config#112 and Mu2e/Production#465 |
|
@FNALbuild run build test with Mu2e/mu2e-trig-config#112, Mu2e/Production#465 |
|
⌛ The following tests have been triggered for 25c3ae5: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 25c3ae5.
N.B. These results were obtained from a build of this Pull Request at 25c3ae5 after being merged into the base branch at 02a3be8. For more information, please check the job page here. |
|
@FNALbuild run build test with Mu2e/mu2e-trig-config#112, Mu2e/Production#465 |
|
⌛ The following tests have been triggered for c77e11d: build (Build queue - API unavailable) |
|
☀️ The build tests passed at c77e11d.
N.B. These results were obtained from a build of this Pull Request at c77e11d after being merged into the base branch at 02a3be8. For more information, please check the job page here. |
This PR introduces code allowing regrowing LoopHelix and KinematicLine fits from appropriate KalSeed collections. It relies on KinKal v3.4.2 or higher. Running this code requires updates to mu2e-trig-config in this PR.
Several core classes were refactored in this work, but the results were only fully exploited in LoopHelix fits. CentralHelix and KL fits still work, but to use the newly available features (such as extrapolation) the fit modules will need to be amended.
There is no reason CentralHelix KalSeeds can't also be regrown, a module for that will be added in a future PR.
Some small bugs were fixed in the course of this development, which may slightly affect the output of tracking.
Some configurations have changed in this PR to improve consistency and maintainability.
Note that this PR augments the KalSeed schema to support regrowing. Regrowing is only possible with seeds created including this schema, so legacy datasets written before this PR cannot have KKTracks regrown.