code cleanup and refactor

MuindiStephen · Mar 11, 2024 · e856ae9 · e856ae9
1 parent acdd14b
commit e856ae9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/app/src/main/java/com/steve_md/smartmkulima/ui/fragments/main/PaymentFragment.kt b/app/src/main/java/com/steve_md/smartmkulima/ui/fragments/main/PaymentFragment.kt
@@ -120,9 +120,9 @@ class PaymentFragment : Fragment(), View.OnClickListener {
             timestamp = timestamp,
             transactionType = Constants.TransactionType.CustomerPayBillOnline,
             amount = amount,
-            partyA = RegEx.sanitizePhoneNumber(phoneNumber)!!,
+            partyA = RegEx.sanitizePhoneNumber(phoneNumber),
             partyB = PARTYB,
-            phoneNumber = RegEx.sanitizePhoneNumber(phoneNumber)!!,
+            phoneNumber = RegEx.sanitizePhoneNumber(phoneNumber),
             callBackURL = CALLBACKURL,
             accountReference = "LIPA NA MPESA",
             transactionDesc = "LIPA NA MPESA C2B"
@@ -168,10 +168,9 @@ class PaymentFragment : Fragment(), View.OnClickListener {
                                 }
                             }
                             displaySnackBar("Saved transaction successfully.")
-                            Timber.tag("Post submitted to the API")
-
+                            Timber.e("Post submitted to the API")
                         } else {
-                            Timber.tag("Response %s")
+                            Timber.e("Response %s")
                         }
                     } catch (e: Exception) {
                         e.printStackTrace()
@@ -180,7 +179,6 @@ class PaymentFragment : Fragment(), View.OnClickListener {
 
                 override fun onFailure(call: Call<StkPushSuccessResponse>, t: Throwable) {
                     Timber.tag(TAG).e(httpException, t.printStackTrace().toString())
-
                 }
             })
     }

diff --git a/app/src/main/java/com/steve_md/smartmkulima/utils/RegEx.kt b/app/src/main/java/com/steve_md/smartmkulima/utils/RegEx.kt
@@ -24,7 +24,6 @@ object RegEx {
 
     fun getPassword(businessShortCode: String, passkey: String, timestamp: String): String? {
         val str = businessShortCode + passkey + timestamp
-        //encode the password to Base64
         return encodeToString(str.toByteArray(), NO_WRAP)
     }
 }
diff --git a/app/src/main/java/com/steve_md/smartmkulima/viewmodel/MainViewModel.kt b/app/src/main/java/com/steve_md/smartmkulima/viewmodel/MainViewModel.kt
@@ -65,6 +65,7 @@ class MainViewModel @Inject constructor(
     }
 }
 
+// UI State
 data class FarmProduceState(
     val isLoading: Boolean = false,
     val error: String? = null,