Add 9-sliced background to chat #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add screenshot how it looks when |
|
|
|
Hmm, I think the console should be a little longer so as not to cut off the scrollbar. |
MoNTE48
reviewed
Jun 28, 2024
src/gui/guiChatConsole.cpp
Outdated
| @@ -348,7 +348,7 @@ void GUIChatConsole::drawBackground() | |||
| draw2DImage9Slice( | |||
| driver, | |||
| m_background, | |||
| core::rect<s32>(0, 0, m_screensize.X, m_height), | |||
| core::rect<s32>(0, 0, m_screensize.X, m_height + 16), | |||
There was a problem hiding this comment.
Well it just made it worse and cropped the background.
The comment is worded badly because I am tired, sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
To do
This PR is a Work in Progress / Ready for Review.
How to test