Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "Buy $MUSIC", block IAP and show error message when no wallet address is available #10

Merged
merged 2 commits into from
May 22, 2019
Merged

Hide "Buy $MUSIC", block IAP and show error message when no wallet address is available #10

merged 2 commits into from
May 22, 2019

Conversation

bengyles
Copy link
Collaborator

Hotfixes for issue #9

@bengyles bengyles requested a review from immartian May 21, 2019 12:03
@immartian
Copy link
Contributor

Looks good to me, the logic is clear although I can't see the UI change.

immartian
immartian approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@immartian immartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@immartian
Copy link
Contributor

the commit it to solve #9 partially, to be accurate.

@immartian immartian merged commit 8f80751 into master May 22, 2019
@immartian
Copy link
Contributor

I've merged since it's been hours but leaving the branch there to solve further parts of the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@immartian immartian immartian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengyles @immartian