content - #1540
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Summary
Registers FavoritesModule, FeedModule, and CommentsModule in app.module.ts — all three were fully implemented (entities, services, controllers, DTOs, guards, tests) but never imported into the app, so their endpoints didn't actually exist at runtime.
Registers the CreateFavorites and AddCommentSoftDeleteAndAudit migrations in migration.datasource.ts for the same reason.
Fixes favorites.controller.spec.ts and feed.controller.spec.ts, which failed to compile their TestingModule because ThrottlerGuard's dependency (ThrottlerModule) wasn't provided — brought them in line with the working pattern already used in comments.controller.spec.ts.
Closes
closes #1436 — Backend: Implement favorites API matching frontend contract
closes #1435 — Backend: Add personalized fan feed endpoint
closes #1434 — Backend: Add comment soft-delete and audit parity with posts
closes #1437
Verification
npx jest favorites feed comments — 10/10 suites, 139/139 tests passing
Confirmed GET/POST/DELETE /v1/favorites, GET /v1/feed/subscriptions, and comment soft-delete (deletedAt + CommentAuditLog) all guarded by JwtAuthGuard
Confirmed NotFoundException thrown for missing creator/favorite targets (404 per acceptance criteria)
Test plan
Run full backend test suite in CI
Run npm run migration:run against a scratch DB to confirm the two new migrations apply cleanly
Smoke-test /v1/favorites and /v1/feed/subscriptions against a running instanc