fix: implement canonical token pin, safe withdraw ordering, remove_authorized, and checked_add - #1543
Merged
Merged
Conversation
…thorized, and checked_add ## Closes MyFanss#1394, MyFanss#1395, MyFanss#1396, MyFanss#1397 ### What does this PR do? - **MyFanss#1394 - Pin creator-deposits to canonical token:** Stores the canonical token address at init. Deposit now validates that the passed token matches the canonical token, reverting with TokenNotAllowed (error code 6) on mismatch. Includes unit tests. - **MyFanss#1395 - Transfer before debiting creator-deposits withdraw ledger:** Reorders the withdraw function so the token.transfer call happens BEFORE the balance is debited. If the transfer fails, the ledger balance remains untouched and accounting stays consistent. - **MyFanss#1396 - Add remove_authorized for creator-earnings depositors:** Adds an admin-only remove_authorized function that removes a depositor from the authorized list and emits an authorized_removed event. Includes tests verifying removed depositors cannot deposit and non-admin calls revert. - **MyFanss#1397 - Use checked_add when crediting creator-earnings deposits:** Replaces the unchecked with in the deposit function, panicking with InvalidAmount on overflow. Includes an overflow regression test.
|
@jpetee21-design Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1394
##Closes #1395
##Closes #1396
##Closes #1397
What does this PR do?
Contract: Pin creator-deposits to canonical token #1394 - Pin creator-deposits to canonical token: Stores the canonical token address at init. Deposit now validates that the passed token matches the canonical token, reverting with TokenNotAllowed (error code 6) on mismatch. Includes unit tests.
Contract: Transfer before debiting creator-deposits withdraw ledger #1395 - Transfer before debiting creator-deposits withdraw ledger: Reorders the withdraw function so the token.transfer call happens BEFORE the balance is debited. If the transfer fails, the ledger balance remains untouched and accounting stays consistent.
Contract: Add remove_authorized for creator-earnings depositors #1396 - Add remove_authorized for creator-earnings depositors: Adds an admin-only remove_authorized function that removes a depositor from the authorized list and emits an authorized_removed event. Includes tests verifying removed depositors cannot deposit and non-admin calls revert.
Contract: Use checked_add when crediting creator-earnings deposits #1397 - Use checked_add when crediting creator-earnings deposits: Replaces the unchecked with in the deposit function, panicking with InvalidAmount on overflow. Includes an overflow regression test.