Clean up converse() code

[danielquinn]

The method signature was different from the parent class, and the else: block was redundant.

As an aside, I'm a new skill developer and this documentation has created more questions than answers for me. From what I'm reading here, all I should need to do is add a converse() method and it'll be triggered before the intent handler... except in my experience it's not triggered at all.

[krisgesling]

Hey Daniel,

Thanks for all the excellent feedback and clear PRs! It's great to have more critical eyes on the docs as we work to build an AI for Everyone.

As discussed in Mycroft Chat the converse method will only trigger for active skills. It's slightly mentioned in the third paragraph but reading it again, this definitely needs improvement.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any contributions to the repo's. This agreement makes it crystal clear that along with your contribution you are offering a license to use it within the confines of this project. You retain ownership of your contribution, this is just a license.

You will also be added to our list of excellent human beings!

Please visit https://mycroft.ai/cla to initiate this one-time signing.

Thank you!