Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Add additional german vocab #123

Open
wants to merge 2 commits into
base: 21.02
Choose a base branch
from

Conversation

eliasball
Copy link

@eliasball eliasball commented May 19, 2022

Description

Fixes some mistranslations and adds additional vocab for german speakers to improve usability.

Type of PR

  • Bugfix
  • Feature implementation

@krisgesling
Copy link
Contributor

Hey there, thanks for the updates.

Are both "Jänner" and "Januar" correct for January?

@domcross
Copy link
Contributor

Are both "Jänner" and "Januar" correct for January?

"Jänner" is "austrian german" (lang code de-at), "Januar" is "german german" (lang code de-de)

@eliasball
Copy link
Author

Are both "Jänner" and "Januar" correct for January?

"Jänner" is "austrian german" (lang code de-at), "Januar" is "german german" (lang code de-de)

Oh, I didn't know that. But as "Januar" is more fitting for de-de, I think the changes should be fitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants