Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Polish language support #152

Open
wants to merge 15 commits into
base: 20.08
Choose a base branch
from

Conversation

r0d0dendr0n
Copy link

Description

Added a language strings for extracting dates from constant relative date strings like "today".
Adds a reasonably good Polish language support for weather related queries.

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Set Mycroft to Polish and ask "Jaka będzie jutro pogoda" or "czy przyda mi się parasol w przyszły weekend".

Documentation

There is no documentation for this skill.

CLA

My CLA has already been submitted.

@r0d0dendr0n r0d0dendr0n changed the title Origin pl 20.08 Improved Polish language support Jan 10, 2021
@r0d0dendr0n
Copy link
Author

It's worth noting that one needs to invoke: mycroft-config set load_langs_on_demand True for lingua_franca to properly load English, along with your primary non-English language. Otherwise you will get a an exception from lingua_franca. Maybe there are other ways that I am not aware of.

@r0d0dendr0n
Copy link
Author

Actualy you need to manualy set load_langs_on_demand = True on config.py of lingua_franca and restart Mycroft. Kind of sucks that lingua_franca seems borked for now.

@krisgesling
Copy link
Contributor

I think for mycroft-core we should be loading English for all installs, simply because that has been a long term assumption in it's development.

The intention is to have this occur in core as that's the code base requiring English, rather than require anyone using LF load English when they have no reason to need it.

Again thanks for flagging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants