[sui-tool] optional backfill of txn digests #24444
Conversation
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
| max_retries: usize, | ||
|
|
||
| /// Backfill epoch transaction digests. Defaults to true. | ||
| /// Required for validators, optional for fullnodes. |
There was a problem hiding this comment.
No way to check this programmatically?
There was a problem hiding this comment.
Alternatively, could we just opt to not backfill on full nodes rather than making it a config flag?
There was a problem hiding this comment.
Good question. Today there isn't a way for sui-tool to know whether it's doing a snapshot restore for a fullnode or a validator. There's a limited set of information provided to the tool, none of which indicates fullnode vs validator
There was a problem hiding this comment.
but I'm doing a refactor of the sui-tool configs for snapshot downloading, it could be a good idea to include a --validator flag (rather than this --backfill-txn-digests flag)
Description
fullnodes shouldn't need this table to be populated prior during formal snapshot restore (fact check me @alex-mysten), we can make it opt-out in the event they're trying to download the snapshot as quickly as possible.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.