Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gifs collaspible by default #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tcrawford-figure
Copy link

@tcrawford-figure tcrawford-figure commented Oct 25, 2023

Addresses: #62

Example output:

<details open>
  <summary><i>do it<i/></summary>
  <img src="https://media4.giphy.com/media/3o84sw9CmwYpAnRRni/giphy.gif"/>
</details>

Rendered output:

do it

@tcrawford-figure tcrawford-figure marked this pull request as ready for review October 25, 2023 18:53
@jmeridth
Copy link
Contributor

@N1ck gentle bump. wdyt?

@N1ck
Copy link
Owner

N1ck commented Apr 12, 2024

@N1ck gentle bump. wdyt?

I've heard several opinions on how we might change or improve the way GIFs are output. I appreciate the simplicity of the extension as it currently stands, and I wouldn't want to make this the default behavior. However, perhaps we could introduce a way to configure the GIF output through a setting.

My initial thought is that you could set a 'template' for how the GIF is rendered, such as:

<details open>
  <summary><i>do it<i/></summary>
  {GIF}
</details>

The extension could then use this template, replacing {GIF} with the actual GIF.

This is not something I currently have time to implement but would be open to PR's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants