Repository navigation
fix: lock affine>=2,<3 to avoid hls-cmr_stac incompat - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I am changing
In #83 we bumped
affinea whole major version, introducing a ser/de bug that we caught in the container benchmark tests:In
affine~=3they changed the base ofAffineto something other than a tuple, eliminating the built-in JSON serialization thathls-cmr_stacrelied upon.I'm taking the short route for now of locking the dependency version rather than fixing upstream. In the medium term I'm going to deprecate the
hls-cmr_stacrepository after lift/shifting the code into this repository undersrc/hls-cmr_stac, just like we did withhls-utilities. This will make it easier to integration test all of this code since it will live in the same repository. Once that's done it will also be feasible to directly call the Python code via functions rather thansubprocess. We avoided doing that so far because many of the HLS utility libraries affect global Python process scope (e.g., manipulatesys.path)