Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stac-api): next link and trailing slash bug in stac api url #358

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

anayeaye
Copy link
Collaborator

@anayeaye anayeaye commented Apr 25, 2024

What

Fix problem in which a stac-fastapi deployed behind a proxy (i.e. customdomain.com) with a custom root path (i.e. /api/stac)

  • Fixed: API does not properly resolve customdomain.com/api/stac -> customdomain.com/api/stac/
  • Fixed: API does not properly use custom root path in next links of paginated responses customdomain.com/api/stac/... links are returned as customdomain.com/... without the custom root path.

The correction is to remove the gateway configuration from the Mangum ASGI handler for the stac-api handler.

Refs

Issue

#343

Testing?

  • I deployed this change manually to the dev veda-backend stack and confirmed that the stac-api url is properly resolved and that the next links now properly include the root path.

@anayeaye anayeaye marked this pull request as ready for review April 25, 2024 23:16
@smohiudd smohiudd self-requested a review April 26, 2024 02:04
@anayeaye anayeaye merged commit 2424fe5 into develop Apr 26, 2024
4 checks passed
@anayeaye anayeaye deleted the fix/api-root-paths branch April 26, 2024 16:54
botanical added a commit that referenced this pull request May 6, 2024
### Breaking
- #356

#### Breaking changes notes
Breaking: `VEDA_COGNITO_DOMAIN` configuration now required along with
one time administrator step to update existing user pool client allowed
callback urls with the ingest-api's URL

### Added
- #342
- #330
- #323

### Changed/Updated
- #355
- #340

### Fixed

1. - #367
2. - #365
3. - #361
4. - #360
5. - #358
8. - #345
9. - #344
12. - #339
13. - #338
14. - #337
15. - #335
16. - #334
17. - #331
20. - #329
21. - #327
22. - #326
23. - #325
24. - #324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants