Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pydantic, Pypgstac and Python Upgrades #449

Merged
merged 11 commits into from
Jan 3, 2025
Merged

fix: Pydantic, Pypgstac and Python Upgrades #449

merged 11 commits into from
Jan 3, 2025

Conversation

ividito
Copy link
Collaborator

@ividito ividito commented Dec 19, 2024

Issue

#435
#436
#437

What?

  • Upgraded Pydantic to version 2, which required several changes to validators. In particular, most decorators changed, and all Optional values must explicitly default to None.
  • Upgraded pypgstac to 0.8.5
  • Upgraded Python runtimes to avoid errors installing Pydantic on earlier Python versions

Testing?

  • Tested manually locally via docker compose, and tested CDK build.

@ividito ividito changed the title Dependency Upgrades Pydantic, Pypgstac and Python Upgrades Dec 19, 2024
@ividito ividito changed the title Pydantic, Pypgstac and Python Upgrades fix: Pydantic, Pypgstac and Python Upgrades Dec 19, 2024
@ividito ividito marked this pull request as ready for review December 23, 2024 15:07
anayeaye
anayeaye reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments/questions. Also just a reminder: we should update our secret for the dev instance with the new pgstac version, too. I'm excited to see this in dev!

ingest_api/runtime/tests/conftest.py Show resolved Hide resolved
ingest_api/runtime/tests/test_registration.py Outdated Show resolved Hide resolved
stac_api/infrastructure/config.py Outdated Show resolved Hide resolved
ividito and others added 2 commits January 3, 2025 12:38
@ividito @anayeaye
now() -> utcnow()
9938dc6 
Co-authored-by: Alexandra Kirk <[email protected]>
@ividito @anayeaye
Unquote None
1df1d17 
Co-authored-by: Alexandra Kirk <[email protected]>
@smohiudd
Copy link
Contributor

smohiudd commented Jan 3, 2025

Local tests worked for me. This looks good!

@smohiudd smohiudd self-requested a review January 3, 2025 18:12
@ividito ividito merged commit 67f7713 into develop Jan 3, 2025
4 checks passed
@ividito ividito deleted the fix/dependency-upgrades branch January 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smohiudd smohiudd smohiudd approved these changes

@anayeaye anayeaye anayeaye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ividito @smohiudd @anayeaye