Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] NLCD Dataset Landing Page #432

Closed
wants to merge 51 commits into from
Closed

[Content] NLCD Dataset Landing Page #432

wants to merge 51 commits into from

Conversation

acblackford
Copy link
Contributor

Why are you creating this Pull Request?

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 9cc56ec
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6733d928f9aaa50008e39260
😎 Deploy Preview https://deploy-preview-432--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
@jerikac
Copy link
Contributor

jerikac commented Aug 16, 2024

@slesaad can we get a final review before merging to main? from what I see things are great! Is there anyone on the UI/front end that needs to review before pushing this to production?

@anayeaye
Copy link
Collaborator

Are these datasets ready for production? We have an automated promotion step coming soon but today we will still need to publish to openveda.cloud/api/stac. Also is there a copy of the json used to publish these collections to staging? We can reverse engineer it, too

  • nlcd-new-urbanization
  • nlcd-annual-conus

cc: @jerikac @acblackford @slesaad

Also: please disregard if you all are already in touch about this, I just noticed the PR with staging data!

@acblackford
Copy link
Contributor Author

@anayeaye I sent @slesaad a copy of the jsons. I believe the datasets are ready for publication if those jsons have all of the necessary information.

@acblackford acblackford changed the title NLCD Dataset Landing Page [Content] NLCD Dataset Landing Page Sep 30, 2024
@acblackford
Copy link
Contributor Author

@snmln @hanbyul-here this needs released as soon as possible. It should have been included in the last release. My apologies if you were not made aware.

Copy link
Contributor

@aboydnw aboydnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the data to load for nlcd-urbanization.data.mdx or nlcd.data.mdx
Maybe that's related to the staging links? I think they should be to prod now, but let me know if I'm mistaken. So, at a minimum we'd want to make sure those are functional.

The other thing I might suggest is to consider making the two nlcd datasets two different layers under the same dataset. I think you could combine the dataset overview content into one file pretty easily, and the layers would still be available separately to reference in stories and visualize in E&A. Feel free to leave as-is if there is a strong reason for it, but I at least want to know that they are visualizing properly, pointing at the correct endpoints.

datasets/nlcd-urbanization.data.mdx Outdated Show resolved Hide resolved
datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
@acblackford
Copy link
Contributor Author

I couldn't get the data to load for nlcd-urbanization.data.mdx or nlcd.data.mdx Maybe that's related to the staging links? I think they should be to prod now, but let me know if I'm mistaken. So, at a minimum we'd want to make sure those are functional.

The other thing I might suggest is to consider making the two nlcd datasets two different layers under the same dataset. I think you could combine the dataset overview content into one file pretty easily, and the layers would still be available separately to reference in stories and visualize in E&A. Feel free to leave as-is if there is a strong reason for it, but I at least want to know that they are visualizing properly, pointing at the correct endpoints.

Per the second suggestion, it was originally set up like that but the collections had to be separate in STAC due to datetime + AOI overlaps so I split them in the dataset.mdx as well. I can combine the mdx though if that is best practice.

@aboydnw
Copy link
Contributor

aboydnw commented Nov 8, 2024

@acblackford The dashboard doesn't necessarily need to reflect the same organization in STAC, so I'd say merge them together in one dataset file if that makes the most sense for users!

@anayeaye we are having trouble visualizing these NLCD datasets, although the urbanization dataset that does not call on the custom colormap is working. Do you think this might be something to do with the colormap that was added here?

@acblackford
Copy link
Contributor Author

@aboydnw @anayeaye I have combined the dataset landing pages into one. The urbanization data is showing up fine but the multi-class NLCD dataset still is not populating.

Copy link
Collaborator

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes after the dataset consolidation. I am still unclear on why the dashboard preview is looking for a cog_default in the nlcd annual conus explorer, though. I am wondering if we have a duplicated id somewhere causing trouble? nlcd properly renders the categorical colormap in openveda.cloud. I'll keep looking

datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
datasets/nlcd.data.mdx Outdated Show resolved Hide resolved
datasets/aerosol-difference.data.mdx Outdated Show resolved Hide resolved
@acblackford acblackford deleted the nlcd branch November 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants