-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content] NLCD Dataset Landing Page #432
Conversation
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Slesa Adhikari <[email protected]>
@slesaad can we get a final review before merging to main? from what I see things are great! Is there anyone on the UI/front end that needs to review before pushing this to production? |
Are these datasets ready for production? We have an automated promotion step coming soon but today we will still need to publish to openveda.cloud/api/stac. Also is there a copy of the json used to publish these collections to staging? We can reverse engineer it, too
cc: @jerikac @acblackford @slesaad Also: please disregard if you all are already in touch about this, I just noticed the PR with staging data! |
@snmln @hanbyul-here this needs released as soon as possible. It should have been included in the last release. My apologies if you were not made aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get the data to load for nlcd-urbanization.data.mdx
or nlcd.data.mdx
Maybe that's related to the staging links? I think they should be to prod now, but let me know if I'm mistaken. So, at a minimum we'd want to make sure those are functional.
The other thing I might suggest is to consider making the two nlcd datasets two different layers under the same dataset. I think you could combine the dataset overview content into one file pretty easily, and the layers would still be available separately to reference in stories and visualize in E&A. Feel free to leave as-is if there is a strong reason for it, but I at least want to know that they are visualizing properly, pointing at the correct endpoints.
Per the second suggestion, it was originally set up like that but the collections had to be separate in STAC due to datetime + AOI overlaps so I split them in the dataset.mdx as well. I can combine the mdx though if that is best practice. |
@acblackford The dashboard doesn't necessarily need to reflect the same organization in STAC, so I'd say merge them together in one dataset file if that makes the most sense for users! @anayeaye we are having trouble visualizing these NLCD datasets, although the urbanization dataset that does not call on the custom colormap is working. Do you think this might be something to do with the colormap that was added here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes after the dataset consolidation. I am still unclear on why the dashboard preview is looking for a cog_default in the nlcd annual conus explorer, though. I am wondering if we have a duplicated id somewhere causing trouble? nlcd properly renders the categorical colormap in openveda.cloud. I'll keep looking
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
Co-authored-by: Alexandra Kirk <[email protected]>
Why are you creating this Pull Request?