Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: notebook to reconcile collection metadata #99

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

botanical
Copy link
Member

@botanical botanical commented Jan 30, 2024

Description

This PR includes a notebook called collection-metadata-reconciliation.ipynb which updates the summaries information for collections in ingestion-data/collections/ and retains the external links of those collections.

Note: this notebook does not reintegrate the retrieved summaries to the collection JSON file in this repo.

Changes Made

  • created a notebook for collection metadata reconciliation which entails using the collections in ingestion-data/collections as a base JSON object and including the merged summaries information and retained external links and posting that newly built JSON object to the ingest endpoint.
  • included a testing_mode to point to dev if True and staging otherwise

Related Issues

#98

Testing Done

  • tested notebook with collections in dev

Additional Comments

I have not set and run the notebook's last cell which will write the updated collections to staging.

@botanical botanical marked this pull request as ready for review February 3, 2024 00:54
"2014-12-31T12:00:00Z"
]
}
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to retain this collection's summaries value? 🤔

@botanical
Copy link
Member Author

📣 The notebook was run against dev since the null stac properties fix was merged and you can view the cell output to see the collections were updated and do not have null properties.
(cc @anayeaye @smohiudd )

@anayeaye
Copy link
Contributor

anayeaye commented Feb 8, 2024

this is the first time in such a long time that we haven't had a metadata error on the browser landing page AND render metadata are in!
https://radiantearth.github.io/stac-browser/#/external/dev.delta-backend.com/api/stac/

browser-home rendered

@smohiudd
Copy link
Contributor

smohiudd commented Feb 8, 2024

Amazing! Well done! Also this proves that our dev ingestor is working for collection ingests at least

@botanical botanical merged commit 6e4a56c into main Feb 8, 2024
2 checks passed
@botanical botanical deleted the feature/jt-issue-98-metadata-reconciliation branch February 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants