fix: Rename React component files from .js to .jsx #1901
Conversation
- Renamed 33 files that import React to have .jsx extension - This prepares the codebase for modern build tools like Vite - Library build with Parcel tested and working correctly - Vite build recognizes JSX syntax (SASS config needed separately) This is a preparatory step for the monorepo migration where we plan to migrate from Parcel to Vite for library builds.
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
I'm not sure the specifics of what should be checked or the review process, so you may want another's 👀 . But this seems like a simple change to me -- if the app transpiles/builds it should be good to go! That said, I saw this thread on adjusting the vite config to accept jsx within js files for esbuild, but haven't tested.
Related, curious if we'll move to tsx and introduce typing? 🚀
|
@ifsimicoded thanks for the review! This is a fairly straightforward change, I believe it’s safe to just rename the files. The current build tooling is quite lax with file extensions, but Vite isn’t (unless you use a workaround as you pointed out). Ideally, our component files should be .tsx, but I don’t think the effort is worth it in this case since the goal is simply to prepare for the migration to Vite. |
Contributes to:
Notes:
This is ready for review.