Feature/AquaCropv7.2 integration #1633
Conversation
Testing was done for the generic crop having a 365-day cycle for 4 restart times (1 Feb, 1 Aug, 1 Dec, 1 Jan next sim), as well as for the AquaCrop Maize file planted on March 22nd. Minor differences are supposably introduced by precision differences (saving restart variables as single precision while AC uses doubles) but have no impact on the final biomass, yield, Tact, Eact. Note that the restart is not working for - perennial crops - GDD crops (will be fixed later) - salinity - (may need a more elaborate list somewhere) No irrigation nor groundwater files were used as it has been decided that those options will be forced from LIS. Irrigation will be introduced in the next developments. Groundwater will not be introduced for the time being.
|
Hi @lbusschaert Can you please open up permissions in your GitHub repo so I can upload changes? @jvgeiger and I are doing a code review and there are some (mostly cosmetic) changes that we would like to make. But I can't push updates to your repo. |
|
Hi @emkemp, I've made you both collaborators to my repo. I think you should be able to push changes now. If not, please let me know. Let me know if I can help with anything else. Thanks |
|
Hi @lbusschaert Hmm, I'm still being blocked. [emkemp@discover31 /discover/nobackup/projects/usaf_lis/emkemp/pr/1633/LISF/ldt]$ git push Please make sure you have the correct access rights @jvgeiger Do I need to push this to my personal GitHub repo first, and then push from there? |
|
Hi @emkemp, You are both still marked as "pending invite", maybe you could try to accept it first?
|
|
Hi @lbusschaert That was it! And my push went through (removing unused local variables). I'll work on additional updates. |
* Fixed identation. * Replaced calls to wrf_error_fatal with write statements and calls to LIS_endrun. * Revised module imports and LIS_misc.h includes. * Replaced hardwired file numbers with calls to LIS_getNextUnitNumber and LIS_releaseUnitNumber. * Standardized path lengths (now uses LIS_CONST_PATH_LEN) * Added preprocessor statements around netCDF code.
|
Okay, I think this code is ready. I will have a final (?) walkthrough with @jvgeiger later this week and we will make a decision. |
|
Also: I did not disturb the LSM source code in lis/surfacemodels/land/ac.7.2/ac_modules. |
|
Thanks for all the work @emkemp |
|
@lbusschaert We will postpone accepting this PR by one week to give @jvgeiger time to add this to his test case suite. But the code looks ready. |
Description
This PR introduces the implementation of a crop model (AquaCropv7.2) in LIS, along with the LDT parameter processing. The implementation was done within the KU Leuven team of Prof. Gabriëlle De Lannoy, mainly by Michel Bechtold and myself.
Research has been done with a preliminary version of AquaCropv7.0 in LIS:
The objective was now to develop a final working version in LIS.
I was visiting the NASA-LIS team in early 2024 and prepared this implementation in collaboration with Sujay Kumar and David Mocko. The implementation is now finalized and has been carefully tested and compared to AquaCrop reference output.
AquaCropv7.2 (ac72) is now part of the surfacemodels/land/. The implementation is documented in
LIS_AC_documentation.pdf
We acknowledge that this is a large PR and we greatly appreciate the time you spend on it. Do not hesitate to contact me in case of any questions ([email protected]).
Testcase
Test cases for LDT and LIS have been added under the ldt/testcases and lis/testcases folders. The data for the test cases are stored in a Zenodo repository organized in the requested format: https://zenodo.org/records/14035685