Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIS/Noah-MPv5.0 coupling #1666

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Conversation

cenlinhe
Copy link

@cenlinhe cenlinhe commented Dec 28, 2024

This PR is to submit the code update of coupling Noah-MPv5.0 with LIS through the GitHub submodule mechanism.

  • The refactored Noah-MP source code under LISF/lis/surfacemodels/land/noahmp.5.0/phys/noahmp is currenlty directly linked to the official community version of NCAR's Noah-MP GitHub: https://github.com/NCAR/noahmp, branch: release-v5.0-LIS
  • The main change of this PR is to create a new noahmp.5.0 folder under LISF/lis/surfacemodels/land/ to couple with the Noah-MPv5.0, with some changes in the lis driver level and documentation part to work with the Noah-MP v5.0.
  • The model code has been tested, benchmarked, and evaluated by the NCAR team in the NCAR's HPC (Derecho) and has recently been tested in NASA's HPC by David Mocko for both LSM run and DA of soil moisture and snow.
  • The new lis.config files for Noah-MPv5.0 are also provided as examples under LISF/lis/configs/Noah-MPv5.0/
  • The model benchmark and evaluation results are currently submitted to Geoscientific Model Development (GMD) through the manuscript of "Benchmarking and evaluating the NASA Land Information System coupled with the refactored Noah-MP land surface model version 5.0"
  • The new Noah-MPv5.0 physics options are described in the LISF/lis/configs/lis.config.adoc
  • Due to the GitHub submodule mechanism, users need to use "git clone --recurse-submodules https://github.com/NASA-LIS/LISF" to download both LIS and Noah-MP source code. This needs to be added to the LIS Readme file.

Code contributor: Cenlin He (NCAR; [email protected])
Model test contributors: Cenlin He (NCAR), Tzu-Shun Lin (NCAR), David Mocko (NASA/LIS)

@dmocko dmocko requested review from dmocko and jvgeiger December 30, 2024 20:16
@dmocko dmocko added enhancement New feature or request AddToTestSuite Documentation Update to documentation (User's Guide or within the code) labels Dec 30, 2024
Not that unused subroutine and function arguments were left in place, to
keep the call signatures undisturbed.  The existence of unused arguments
is found in other LSM interfaces, and this should be fixed in a
more widespread (and separate) pull request.
@emkemp
Copy link
Contributor

emkemp commented Jan 31, 2025

Since @jvgeiger is wrapping up a different PR before working on this one, I took the liberty of test compiling the code. Compilation was successful (using the Intel 2023.2.1 compiler), but strict checks indicated quite a few unused variables. I went ahead and pushed changes to remove most of these variables and save a little memory. (Unused arguments are left undisturbed.)

@jvgeiger
Copy link
Contributor

jvgeiger commented Mar 7, 2025

@dmocko , I pushed my commits into the pull request. I believe that I resolved all the issues that we discussed. Would you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AddToTestSuite Documentation Update to documentation (User's Guide or within the code) enhancement New feature or request HighPriority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants