-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIS/Noah-MPv5.0 coupling #1666
base: master
Are you sure you want to change the base?
LIS/Noah-MPv5.0 coupling #1666
Conversation
Not that unused subroutine and function arguments were left in place, to keep the call signatures undisturbed. The existence of unused arguments is found in other LSM interfaces, and this should be fixed in a more widespread (and separate) pull request.
Since @jvgeiger is wrapping up a different PR before working on this one, I took the liberty of test compiling the code. Compilation was successful (using the Intel 2023.2.1 compiler), but strict checks indicated quite a few unused variables. I went ahead and pushed changes to remove most of these variables and save a little memory. (Unused arguments are left undisturbed.) |
lis/surfacemodels/land/noahmp.5.0/routing/noahmp50_getrunoffs_hymap2.F90
Show resolved
Hide resolved
This file/routine is not used in NoahMPv5.
These files/routines are not needed anymore. This interface was removed.
I am replacing these with tests from David Mocko.
These came from David Mocko.
@dmocko , I pushed my commits into the pull request. I believe that I resolved all the issues that we discussed. Would you take a look? |
This PR is to submit the code update of coupling Noah-MPv5.0 with LIS through the GitHub submodule mechanism.
Code contributor: Cenlin He (NCAR; [email protected])
Model test contributors: Cenlin He (NCAR), Tzu-Shun Lin (NCAR), David Mocko (NASA/LIS)