Add some missing cstdint includes #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of GCC have become more strict about import of
known-size number types.
Currently, compiling IKOS leads to errors similar to the following:
In file included from /<<PKGBUILDDIR>>/core/include/ikos/core/domain/machine_int/abstract_domain.hpp:47,
from /<<PKGBUILDDIR>>/core/include/ikos/core/domain/machine_int/interval.hpp:46,
from /<<PKGBUILDDIR>>/analyzer/src/analysis/pointer/pointer.cpp:48:
/<<PKGBUILDDIR>>/core/include/ikos/core/domain/machine_int/operator.hpp:97:24: error: ‘uint64_t’ has not been declared
97 | uint64_t result_bit_width,
| ^~~~~~~~
This commits adds cstdint to the list of includes wherever a numerical
type with a known or fixed size is used.
ivanperez-keera
force-pushed
the
add_cstdint_includes
branch
from
73c8166
to
79d335a
Compare
|
@swt2c All good. I'm just adding some doc locally to the git repo. I only changed the commit message. I'll wait a few minutes for this to build. Thanks! EDIT: We also have to do the CLA. I almost forgot! |
|
I know this is a small patch, but can you please sign one of the two CLAs: https://github.com/NASA-SW-VnV/ikos/tree/master/doc/contribute. Send it by email to [email protected], CC-ing me Thanks! |
Done. |
|
Thanks! Received! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of GCC have become more strict about this, resulting in errors similar to the following: