Update subtraction ale script and data files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
reviewed
Jun 8, 2021
| @@ -1,4 +1,4 @@ | |||
| pip install argparse | |||
| pip install nilearn | |||
| pip install nimare | |||
| pip install nibabel | |||
| pip install nimare==0.0.3 | |||
There was a problem hiding this comment.
Is there a particular reason to pin to 0.0.3?
There was a problem hiding this comment.
It should maybe be >= 0.0.3, I think there's a change to the sleuth-to-dset conversion function in there.
There was a problem hiding this comment.
We're on 0.0.9rc2 (I think 0.0.9 will be the version for the paper), and there have been improvements to the subtraction analysis method, along with various fixes to a variety of things. We could look through the release history to see if there is anything especially relevant for these analyses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
code/nimare-ale-subtraction.pyto accept gzipped, pickled dataset files;code/make-figs.py, to include diverging color maps for subtraction analyses; andcode/setup.sh, to specify versions of NiMARE and nibabel. Addedcode/subset-nimare-ds.pyto create "Not < Construct >" datasets for additional subtraction analyses.