-
Notifications
You must be signed in to change notification settings - Fork 167
Fix: Remove format on read for parse_variables_clamp #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mjs2369
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Helen. This is missing a fix for mpas_ocn:
DART/models/mpas_ocn/model_mod.f90
Lines 3964 to 3976 in e08756e
| bound = trim(bounds_table(2,n)) | |
| if ( bound /= 'NULL' .and. bound /= '' ) then | |
| read(bound,'(d16.8)') lower_bound | |
| else | |
| lower_bound = missing_r8 | |
| endif | |
| bound = trim(bounds_table(3,n)) | |
| if ( bound /= 'NULL' .and. bound /= '' ) then | |
| read(bound,'(d16.8)') upper_bound | |
| else | |
| upper_bound = missing_r8 | |
| endif |
Good catch, however I have left mpas_ocn alone as it does not compile (no quickbuild.sh). |
mjs2369
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean fix
c948c16 to
ac2737e
Compare
Description:
Parse_variables_clamp in the default model_mod had format d16.8 in the read statement. This caused integers to be read as value * 10-8 following the fortran standard.
This pull request removes the format on the read for parse_variables_clamp and from the reads in the modules this routine was based off, wrf, mpas_atm, tiegcm
Fixes issue
fixes #1022
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Changed the test_parse_args to check integers in the namelist.
Checklist for merging
Checklist for release
Testing Datasets