Added the chimere model, and fixed a minor bug #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blychs
reviewed
Nov 12, 2025
Collaborator
blychs
left a comment
blychs
left a comment
There was a problem hiding this comment.
This looks good to me.
The only reason I'm not approving it yet is that I believe that the chimere reader hasn't been merged into monetio yet?
bbakernoaa
reviewed
Dec 15, 2025
melodies_monet/driver.py
Outdated
| 'var_list': list_input_var, | ||
| "surf_only": control_dict['model'][self.label].get('surf_only', False) | ||
| }) | ||
| self.obj = mio.models._chimere_mm.open_mfdataset(self.files, **self.mod_kwargs) |
Contributor
There was a problem hiding this comment.
we should move away from the _modelname_mm in monetio. These should all be exposed to the main readers
Author
There was a problem hiding this comment.
Done! fixed in monetio and the reference in driver
AntonioTorga
force-pushed
the
develop
branch
from
814a9af to
bf0dace
Compare
bbakernoaa
approved these changes
Dec 19, 2025
Contributor
|
Once the conflicts are resolved it looks good. |
Author
|
Forgot to make it a different pull request. Going to do that in the morning so we can keep a clean git log. |
AntonioTorga
force-pushed
the
develop
branch
from
a49580d to
bf0dace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the chimere model adapter that i also pull request'ed to monetio.
Fixed a minor bug in border definition for spatial_overlay graphs.
Might need to confirm that it was non intended behaviour but when making custom polygons for data filtering and creating a spatial_overlay graph an error occured where a float was expected but an xarray.dataarray (or dataset can't recall now) was provided.
You can check that in other if-statements around the fix the values are set to floats (like when the borders are provided for CONUS or EPA regions)
I just changed the order of the operations so it actually provides the minlat, minlon, ... for the vmodel data.