Combo UFS-dev PR #312 and #310

[grantfirl]

SOURCE: @grantfirl

DESCRIPTION OF CHANGES:

• Host changes needed for Combo UFS-dev PR #310 and #312 ccpp-physics#1173. Changes are more-or-less identical to Replace GFS_interstitial phys_reset and rad_reset routines with combined reset routine NOAA-EMC/ufsatm#1004

ISSUE: None

ASSOCIATED PRs:

NCAR/ccpp-physics#1173

TESTS CONDUCTED: SCM RTs

This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.

Associated ufs/dev PR:

• Update GFS_debug (GFS_interstitialtoscreen) ufs-community/ccpp-physics#310
• Reduce "Explicit interface or EXTERNAL declaration is required" compiler warnings in sfcsub ufs-community/ccpp-physics#312

Associated ufsatm PR:

• Replace GFS_interstitial phys_reset and rad_reset routines with combined reset routine NOAA-EMC/ufsatm#1004
• No changes needed from Address some compiler warnings in UFSATM NOAA-EMC/ufsatm#1025

Associated NCAR PR:

• Combo UFS-dev PR #310 and #312 ccpp-physics#1173

---

REGRESSION TEST CHANGES: Supposed to be none.

[grantfirl]

Note that every RT changed results. This is unexpected. I will investigate, but I suspect it has to do with the new way of resetting the interstitial variables that may affect some output that gets written.

[grantfirl]

After recreating baselines from main locally on my Mac, running RTs locally using the PR branch, I can replicate that all RTs are changing baselines. Further, I ran nccmp on one particular test and found the following:

Variable Group Count Sum AbsSum Min Max Range Mean StdDev
rad_cloud_fraction / 11311 7985.43 7985.43 0.00542935 1 0.994571 0.705988 0.380914
rad_cloud_lwp / 3849 95558.4 95558.4 1.03827e-06 180.229 180.229 24.8268 25.2066
rad_eff_rad_ql / 22733 83006.1 83006.1 2.5 11.6057 9.10565 3.65135 2.66196
rad_cloud_iwp / 7600 60590.7 60590.7 3.41559e-08 59.7398 59.7398 7.97246 10.0234
rad_eff_rad_qi / 22733 303467 303467 2.5 125 122.5 13.3492 21.8164
rad_cloud_rwp / 5861 16906.1 16906.1 1.7046e-07 24.8793 24.8793 2.88451 3.35961
rad_eff_rad_qr / 22733 2.2733e+07 2.2733e+07 1000 1000 0 1000 0
rad_cloud_swp / 7403 31065.3 31065.3 1.02468e-07 37.0347 37.0347 4.19631 6.44266
rad_eff_rad_qs / 22733 1.63363e+06 1.63363e+06 5 975.439 970.439 71.8615 149.056

These variables had been being reset on radiation intervals and are now being reset with everything else, so the output will be different. This is expected after all, so I think that this PR is good to go. It's not actually changing the state, just how certain interstitial variables are being written out.

[scrasmussen]

Changes look consistent with NOAA-EMC/ufsatm#1004.

@grantfirl if the differences from the baselines look good to you, it works for me. Thanks for testing and looking into that!